* [PATCH] net: bridge: remove unnecessary cast from netdev_priv()
@ 2024-07-15 2:44 Chen Ni
2024-07-15 8:04 ` Nikolay Aleksandrov
0 siblings, 1 reply; 3+ messages in thread
From: Chen Ni @ 2024-07-15 2:44 UTC (permalink / raw)
To: roopa, razor, davem, edumazet, kuba, pabeni
Cc: bridge, netdev, linux-kernel, Chen Ni
Remove unnecessary cast of void * returned by netdev_priv().
Fixes: 928990631327 ("net: bridge: add notifications for the bridge dev on vlan change")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
net/bridge/br_netlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index f17dbac7d828..d02cc1497281 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -1085,7 +1085,7 @@ static int br_setport(struct net_bridge_port *p, struct nlattr *tb[],
int br_setlink(struct net_device *dev, struct nlmsghdr *nlh, u16 flags,
struct netlink_ext_ack *extack)
{
- struct net_bridge *br = (struct net_bridge *)netdev_priv(dev);
+ struct net_bridge *br = netdev_priv(dev);
struct nlattr *tb[IFLA_BRPORT_MAX + 1];
struct net_bridge_port *p;
struct nlattr *protinfo;
@@ -1143,7 +1143,7 @@ int br_setlink(struct net_device *dev, struct nlmsghdr *nlh, u16 flags,
/* Delete port information */
int br_dellink(struct net_device *dev, struct nlmsghdr *nlh, u16 flags)
{
- struct net_bridge *br = (struct net_bridge *)netdev_priv(dev);
+ struct net_bridge *br = netdev_priv(dev);
struct net_bridge_port *p;
struct nlattr *afspec;
bool changed = false;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: bridge: remove unnecessary cast from netdev_priv()
2024-07-15 2:44 [PATCH] net: bridge: remove unnecessary cast from netdev_priv() Chen Ni
@ 2024-07-15 8:04 ` Nikolay Aleksandrov
2024-07-16 13:30 ` Jiri Pirko
0 siblings, 1 reply; 3+ messages in thread
From: Nikolay Aleksandrov @ 2024-07-15 8:04 UTC (permalink / raw)
To: Chen Ni, roopa, davem, edumazet, kuba, pabeni
Cc: bridge, netdev, linux-kernel
On 15/07/2024 05:44, Chen Ni wrote:
> Remove unnecessary cast of void * returned by netdev_priv().
>
> Fixes: 928990631327 ("net: bridge: add notifications for the bridge dev on vlan change")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> net/bridge/br_netlink.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
This is not a fix, the code isn't broken and it doesn't violate
anything.
Nacked-by: Nikolay Aleksandrov <razor@blackwall.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: bridge: remove unnecessary cast from netdev_priv()
2024-07-15 8:04 ` Nikolay Aleksandrov
@ 2024-07-16 13:30 ` Jiri Pirko
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2024-07-16 13:30 UTC (permalink / raw)
To: Nikolay Aleksandrov
Cc: Chen Ni, roopa, davem, edumazet, kuba, pabeni, bridge, netdev,
linux-kernel
Mon, Jul 15, 2024 at 10:04:26AM CEST, razor@blackwall.org wrote:
>On 15/07/2024 05:44, Chen Ni wrote:
>> Remove unnecessary cast of void * returned by netdev_priv().
>>
>> Fixes: 928990631327 ("net: bridge: add notifications for the bridge dev on vlan change")
>> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
>> ---
>> net/bridge/br_netlink.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
>This is not a fix, the code isn't broken and it doesn't violate
>anything.
Yeah, it's cosmetics, send it to net-next without "Fixes" tag.
>
>Nacked-by: Nikolay Aleksandrov <razor@blackwall.org>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-16 13:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-15 2:44 [PATCH] net: bridge: remove unnecessary cast from netdev_priv() Chen Ni
2024-07-15 8:04 ` Nikolay Aleksandrov
2024-07-16 13:30 ` Jiri Pirko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox