Netdev List
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org
Subject: [selftest] udpgro test report fail but passed
Date: Tue, 13 Aug 2024 11:29:24 +0800	[thread overview]
Message-ID: <ZrrTFI4QBZvXoXP6@Laptop-X1> (raw)

Hi Paolo,

In our recently internal testing, the udpgro.sh test reports failed but it
still return 0 as passed. e.g.

```
ipv6
 no GRO                                  ok
 no GRO chk cmsg                         ok
 GRO                                     ./udpgso_bench_rx: recv: bad packet len, got 1452, expected 14520

failed
 GRO chk cmsg                            ./udpgso_bench_rx: recv: bad packet len, got 1452, expected 14520

failed
 GRO with custom segment size            ./udpgso_bench_rx: recv: bad packet len, got 500, expected 14520

failed
 GRO with custom segment size cmsg       ./udpgso_bench_rx: recv: bad packet len, got 500, expected 14520

failed
 bad GRO lookup                          ok
 multiple GRO socks                      ./udpgso_bench_rx: recv: bad packet len, got 1452, expected 14520

./udpgso_bench_rx: recv: bad packet len, got 1452, expected 14520

failed
```

For run_one_2sock testing, I saw

```
        ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 1000 -R 10 ${rx_args} -p 12345 &
        ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 2000 -R 10 ${rx_args} && \
                echo "ok" || \
                echo "failed" &
        ...
        ./udpgso_bench_tx ${tx_args}
        ret=$?
        wait $(jobs -p)
        return $ret
```

So what's the effect if it echo "failed" while ret == 0?

Thanks
Hangbin

             reply	other threads:[~2024-08-13  3:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-13  3:29 Hangbin Liu [this message]
2024-08-13  8:24 ` [selftest] udpgro test report fail but passed Paolo Abeni
2024-08-13  9:57   ` Hangbin Liu
2024-08-13 14:37     ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrrTFI4QBZvXoXP6@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox