Re: [selftest] udpgro test report fail but passed

[Hangbin Liu <liuhangbin@gmail.com>]

On Tue, Aug 13, 2024 at 10:24:34AM +0200, Paolo Abeni wrote:
> It's just pour integration between the script and the selftests harness.
> 
> The script should capture the pid of the background UDP receiver, wait poll
> for a bit for such process termination after that the sender completes, then
> send a termination signal, capture the receiver exit code and use it to emit
> the success/fail message and update the script return code.

If that's the case, we shouldn't echo the result as the return value will
always be 0. Is the following change you want? e.g.

@@ -115,16 +113,14 @@ run_one_2sock() {
 	cfg_veth
 
 	ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 1000 -R 10 ${rx_args} -p 12345 &
-	ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 2000 -R 10 ${rx_args} && \
-		echo "ok" || \
-		echo "failed" &
+	ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 2000 -R 10 ${rx_args} &
 
 	wait_local_port_listen "${PEER_NS}" 12345 udp
 	./udpgso_bench_tx ${tx_args} -p 12345
 	wait_local_port_listen "${PEER_NS}" 8000 udp
 	./udpgso_bench_tx ${tx_args}
-	ret=$?
 	wait $(jobs -p)
+	ret=$?
 	return $ret
 }

> 
> Could you please have a shot at the above?
> 
> BTW I sometimes observed similar failures in the past when the bpf program
> failed to load.

From my log I didn't see bpf load failure..

Thanks
Hangbin