From: Joe Damato <jdamato@fastly.com>
To: Eric Dumazet <edumazet@google.com>
Cc: netdev@vger.kernel.org, amritha.nambiar@intel.com,
sridhar.samudrala@intel.com, sdf@fomichev.me, peter@typeblog.net,
m2shafiei@uwaterloo.ca, bjorn@rivosinc.com, hch@infradead.org,
willy@infradead.org, willemdebruijn.kernel@gmail.com,
skhawaja@google.com, kuba@kernel.org,
Martin Karsten <mkarsten@uwaterloo.ca>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 3/6] net: Add control functions for irq suspension
Date: Fri, 23 Aug 2024 19:02:08 +0100 [thread overview]
Message-ID: <ZsjOoJBQBls7dl8o@LQ3V64L9R2> (raw)
In-Reply-To: <CANn89iJmp2yviC=Z-n7-=suw8N=SJ7uoy0xy5LMQRKDhubNBZg@mail.gmail.com>
On Fri, Aug 23, 2024 at 07:56:32PM +0200, Eric Dumazet wrote:
> On Fri, Aug 23, 2024 at 7:31 PM Joe Damato <jdamato@fastly.com> wrote:
> >
> > From: Martin Karsten <mkarsten@uwaterloo.ca>
> >
> > The napi_suspend_irqs routine bootstraps irq suspension by elongating
> > the defer timeout to irq_suspend_timeout.
> >
> > The napi_resume_irqs routine effectly cancels irq suspension by forcing
> > the napi to be scheduled immediately.
> >
> > Signed-off-by: Martin Karsten <mkarsten@uwaterloo.ca>
> > Co-developed-by: Joe Damato <jdamato@fastly.com>
> > Signed-off-by: Joe Damato <jdamato@fastly.com>
> > Tested-by: Joe Damato <jdamato@fastly.com>
> > Tested-by: Martin Karsten <mkarsten@uwaterloo.ca>
> > ---
>
> You have not CC me on all the patches in the series, making the review
> harder then necessary.
My sincere apologies, Eric, and thank you for your time reviewing
this.
I used a script I'd been using for a while to generate the CC list,
but it clearly has a bug.
For any future revisions I will be sure to explicitly include you.
next prev parent reply other threads:[~2024-08-23 18:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 17:30 [PATCH net-next 0/6] Suspend IRQs during application busy periods Joe Damato
2024-08-23 17:30 ` [PATCH net-next 1/6] net: Add sysfs parameter irq_suspend_timeout Joe Damato
2024-08-23 17:39 ` Eric Dumazet
2024-08-23 20:15 ` Joe Damato
2024-08-23 17:30 ` [PATCH net-next 2/6] net: Suspend softirq when prefer_busy_poll is set Joe Damato
2024-08-23 17:30 ` [PATCH net-next 3/6] net: Add control functions for irq suspension Joe Damato
2024-08-23 17:56 ` Eric Dumazet
2024-08-23 18:02 ` Joe Damato [this message]
2024-08-23 18:14 ` Eric Dumazet
2024-08-23 20:21 ` Martin Karsten
2024-08-23 17:30 ` [PATCH net-next 4/6] eventpoll: Trigger napi_busy_loop, if prefer_busy_poll is set Joe Damato
2024-08-23 17:30 ` [PATCH net-next 5/6] eventpoll: Control irq suspension for prefer_busy_poll Joe Damato
2024-08-23 17:30 ` [PATCH net-next 6/6] docs: networking: Describe irq suspension Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsjOoJBQBls7dl8o@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=amritha.nambiar@intel.com \
--cc=bigeasy@linutronix.de \
--cc=bjorn@rivosinc.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hch@infradead.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=m2shafiei@uwaterloo.ca \
--cc=mkarsten@uwaterloo.ca \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peter@typeblog.net \
--cc=sdf@fomichev.me \
--cc=skhawaja@google.com \
--cc=sridhar.samudrala@intel.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox