From: Andrew Lunn <andrew@lunn.ch>
To: Thangaraj Samynathan <thangaraj.s@microchip.com>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, bryan.whitehead@microchip.com,
UNGLinuxDriver@microchip.com, linux@armlinux.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/5] net: lan743x: Add PCS/XPCS support for SFP on PCI11x1x
Date: Thu, 14 May 2026 15:16:32 +0200 [thread overview]
Message-ID: <a044fcc6-554f-4edb-ad49-194d11eb6124@lunn.ch> (raw)
In-Reply-To: <20260514105028.42942-6-thangaraj.s@microchip.com>
> Integrate the XPCS instance with phylink by providing a mac_select_pcs
> callback. Support SGMII and 2.5GBASE-X interfaces in phylink
Not 1000BaseX?
>
> switch (adapter->phy_interface) {
> case PHY_INTERFACE_MODE_SGMII:
> + case PHY_INTERFACE_MODE_2500BASEX:
> __set_bit(PHY_INTERFACE_MODE_SGMII,
> adapter->phylink_config.supported_interfaces);
> __set_bit(PHY_INTERFACE_MODE_1000BASEX,
So it looks like there is some sort of mixup with SGMII and
1000BaseX. They are different things. Can adapter->phy_interface be
set to PHY_INTERFACE_MODE_1000BASEX? Should there be a case: for it?
It could be the broken documentation, using SGMII to mean PCS, has
resulted in other problems with 1000BaseX not being implemented
correct? You might want to look at all the "SGMII" code and fixup all
the 1000BaseX issues.
Andrew
prev parent reply other threads:[~2026-05-14 13:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 10:50 [PATCH v4 0/5] net: lan743x: Add SFP support for PCI11x1x Thangaraj Samynathan
2026-05-14 10:50 ` [PATCH v4 1/5] net: lan743x: rename is_sgmii_en to is_pcs_en Thangaraj Samynathan
2026-05-14 12:38 ` Andrew Lunn
2026-05-14 10:50 ` [PATCH v4 2/5] net: lan743x: read SFP straps from PCI11x1x device Thangaraj Samynathan
2026-05-14 12:47 ` Andrew Lunn
2026-05-14 10:50 ` [PATCH v4 3/5] net: lan743x: Add support to software-nodes for SFP Thangaraj Samynathan
2026-05-14 12:57 ` Andrew Lunn
2026-05-14 13:02 ` Andrew Lunn
2026-05-14 10:50 ` [PATCH v4 4/5] net: lan743x: Register SFP platform device for PCI11x1x Thangaraj Samynathan
2026-05-14 10:50 ` [PATCH v4 5/5] net: lan743x: Add PCS/XPCS support for SFP on PCI11x1x Thangaraj Samynathan
2026-05-14 13:16 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a044fcc6-554f-4edb-ad49-194d11eb6124@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thangaraj.s@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox