Netdev List
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Kuniyuki Iwashima <kuniyu@google.com>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Neal Cardwell <ncardwell@google.com>,
	Willem de Bruijn <willemb@google.com>,
	David Ahern <dsahern@kernel.org>,
	Ido Schimmel <idosch@nvidia.com>
Cc: Simon Horman <horms@kernel.org>,
	Kuniyuki Iwashima <kuni1840@gmail.com>,
	netdev@vger.kernel.org, Daehyeon Ko <4ncienth@gmail.com>,
	Hyunwoo Kim <imv4bel@gmail.com>
Subject: Re: [PATCH v1 net-next 2/2] ipv6: Remove IPV6_ADDRFORM.
Date: Fri, 4 Sep 2026 11:10:27 +0200	[thread overview]
Message-ID: <a1c9d9ae-68cd-4153-9bf3-38be1cd8970d@redhat.com> (raw)
In-Reply-To: <20260904033543.2635540-3-kuniyu@google.com>

On 9/4/26 5:35 AM, Kuniyuki Iwashima wrote:
> Recently, IPV6_ADDRFORM has received many AI-driven bug reports.
> Fixing them properly would needlessly churn the fast paths in TCP
> and UDP.
> 
> IPV6_ADDRFORM was initially introduced in RFC 2133 in 1997,
> but only two years later, it was removed from RFC 2553 in 1999.
> 
> In 2026, modern applications natively support dual-stack sockets;
> notably, systemd's socket activation does not use IPV6_ADDRFORM.
> 
> Also, getsockopt(IPV6_ADDRFORM) can be replaced with SO_DOMAIN.
> 
> Let's remove IPV6_ADDRFORM.

Yes please!

Acked-by: Paolo Abeni <pabeni@redhat.com>

> Later, we can remove sk->sk_prot_creator and revert commit
> c26c192c3d48 ("udp: properly deal with xfrm encap and ADDRFORM").

I'm not 110% sure syzkaller or others will find a way to still trigger
the race addressed there, but I guess we will see.

Also I guess we can get rid of several READ_ONCE(sk->sk_family).

/P


      reply	other threads:[~2026-09-04  9:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04  3:35 [PATCH v1 net-next 0/2] net: Disallow buggy TCP transitions and IPV6_ADDRFORM Kuniyuki Iwashima
2026-09-04  3:35 ` [PATCH v1 net-next 1/2] tcp: Do not allow buggy transitions between ehash and lhash2 Kuniyuki Iwashima
2026-09-04 11:32   ` Jakub Sitnicki
2026-09-04  3:35 ` [PATCH v1 net-next 2/2] ipv6: Remove IPV6_ADDRFORM Kuniyuki Iwashima
2026-09-04  9:10   ` Paolo Abeni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a1c9d9ae-68cd-4153-9bf3-38be1cd8970d@redhat.com \
    --to=pabeni@redhat.com \
    --cc=4ncienth@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=imv4bel@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kuni1840@gmail.com \
    --cc=kuniyu@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox