From: Matthieu Baerts <matttbe@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: martineau@kernel.org, geliang@kernel.org, davem@davemloft.net,
edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, fw@strlen.de, dmytro@shytyi.net,
netdev@vger.kernel.org, mptcp@lists.linux.dev,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
mason@kernel.org
Subject: Re: [PATCH net 6/7] mptcp: don't send a FIN before the pending data on fallback
Date: Wed, 18 Nov 2026 23:03:37 +0100 [thread overview]
Message-ID: <a25b7f89-88e4-419e-83cc-83c5d1776421@kernel.org> (raw)
In-Reply-To: <179495459093.3136.11317086858664422664@kernel.org>
Hello,
On 17/11/2026 23:29, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 2 · Low: 0
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
Please see below.
(...)
>> diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
>> index 011e73d04ee60..7d226ee38315d 100644
>> --- a/net/mptcp/protocol.h
>> +++ b/net/mptcp/protocol.h
>> @@ -1333,7 +1333,11 @@ static inline bool mptcp_try_fallback(struct sock *ssk, int fb_mib)
>> msk = mptcp_sk(sk);
>> if (!__mptcp_try_fallback(msk, fb_mib))
>> return false;
>> - if (READ_ONCE(msk->snd_data_fin_enable) && !(ssk->sk_shutdown & SEND_SHUTDOWN)) {
>> +
>> + /* no FIN before new data: see mptcp_check_send_data_fin() */
>> + if (READ_ONCE(msk->snd_data_fin_enable) &&
>> + !before64(READ_ONCE(msk->snd_nxt) + 1, READ_ONCE(msk->write_seq)) &&
>> + !(ssk->sk_shutdown & SEND_SHUTDOWN)) {
>
> [Severity: Medium]
> With this change, the subflow FIN is deferred while new data is still
> pending, and mptcp_check_send_data_fin() is expected to send it once
> that data has been pushed. check_fully_established() now calls
> __mptcp_check_push() after a successful fallback, so that path is
> covered. What about the other mptcp_try_fallback() callers?
>
> subflow_check_data_avail() falls back on MAPPING_NODSS and
> MAPPING_DUMMY:
>
> net/mptcp/subflow.c:subflow_check_data_avail() {
> ...
> if (!mptcp_try_fallback(ssk, MPTCP_MIB_DSSFALLBACK)) {
> ...
> }
>
> mptcp_dss_corruption() does the same on a corrupted mapping:
>
> net/mptcp/protocol.c:mptcp_dss_corruption() {
> ...
> if (!mptcp_try_fallback(ssk, MPTCP_MIB_DSSCORRUPTIONFALLBACK)) {
> ...
> }
>
> In both cases, mptcp_incoming_options() has already run for this packet
> while MPTCP_FALLBACK_DONE was still clear. Without a DSS option, it
> returns early, before ack_update_msk() and __mptcp_check_push() are
> reached. Neither caller pushes the pending data once the fallback has
> succeeded.
>
> Before this patch, the FIN was sent here unconditionally. The data was
> lost, but the connection could still be closed. Now the FIN is skipped.
> If the peer doesn't send anything else, what pushes the data from
> msk->first_pending and then calls mptcp_check_send_data_fin()?
>
> The retransmit timer doesn't seem to help either. If there is unacked
> data at the head of the rtx_queue, __mptcp_push_retrans() returns -1
> on a fallen-back msk, and __mptcp_retrans() jumps to clear_scheduled:
>
> net/mptcp/protocol.c:__mptcp_retrans() {
> ...
> /* Can fail only in case of fallback. */
> len = __mptcp_push_retrans(sk, dfrag, retrans_seq);
> if (len < 0)
> goto clear_scheduled;
> ...
> }
>
> This skips mptcp_check_and_set_pending(sk), so the pending data isn't
> scheduled from there either.
>
> Couldn't the connection then be left with both the pending data and
> the deferred FIN stuck, so the shutdown never completes? Should
> subflow_check_data_avail() and mptcp_dss_corruption() also trigger a
> push after a successful fallback, like check_fully_established() does?
> Or is another path expected to flush this data?
Somehow pre-existing: Before this patch, this pending data was lost: the
peer silently got a truncated stream. Now, the data and the FIN are sent
at the next push, e.g. on the next ACK or window update from the peer.
This is the same as for pending data without shutdown, which was already
not pushed after these fallbacks: this is a pre-existing issue, not a
regression. It can be handled in a follow-up, if a stall can be
reproduced, but I didn't manage to reproduce it so far.
> [Severity: Medium]
> Is this lockless check ordered against the writer?
>
> mptcp_try_fallback() can run in BH context with only the ssk lock held.
> One example is check_fully_established(), when the 3rd ACK arrives without
> MPTCP options:
>
> net/mptcp/options.c:check_fully_established() {
> ...
> if (!mptcp_try_fallback(ssk, MPTCP_MIB_MPCAPABLEDATAFALLBACK)) {
> ...
> }
>
> The writer is __mptcp_wr_shutdown(), called from mptcp_shutdown() and
> mptcp_close(). It holds only the msk socket lock, not the ssk lock or
> msk->fallback_lock:
>
> net/mptcp/protocol.c:__mptcp_wr_shutdown() {
> ...
> WRITE_ONCE(msk->write_seq, msk->write_seq + 1);
> WRITE_ONCE(msk->snd_data_fin_enable, 1);
> ...
> }
>
> Nothing orders these two stores. Nothing orders the three READ_ONCE()
> loads in mptcp_try_fallback() either. The spin_lock_bh() on
> msk->fallback_lock in __mptcp_try_fallback() doesn't help, because the
> writer never takes that lock.
>
> On a weakly ordered CPU such as arm64 or POWER, could the BH reader see
> snd_data_fin_enable == 1 together with the old write_seq?
>
> Suppose exactly one byte of new data is still unsent, so snd_nxt + 1
> equals the old write_seq. The new check then evaluates to true, and
> tcp_shutdown(ssk) sends the FIN before that byte.
>
> After that, mptcp_check_send_data_fin() returns early on the writer side:
>
> net/mptcp/protocol.c:mptcp_check_send_data_fin() {
> ...
> if (!msk->snd_data_fin_enable || msk->snd_nxt + 1 != msk->write_seq ||
> mptcp_send_head(sk))
> return;
> ...
> }
>
> The byte can't be pushed later either. The subflow is now in FIN_WAIT1 or
> LAST_ACK, so __tcp_can_send() fails in __mptcp_subflow_active().
>
> Wouldn't this truncate the stream in the same way this patch is meant to
> prevent, only within a narrower window?
This is theoretical: it needs a weakly ordered CPU, a shutdown racing
with a fallback, and exactly one byte left unsent. Without this patch,
the stream is always truncated in this case, so not a regression, and I
don't think it is worth blocking this patch for this theoretical reason.
> Would it close the window to publish snd_data_fin_enable with
> smp_store_release() after the write_seq update, and read it with
> smp_load_acquire() in mptcp_try_fallback()? An smp_wmb()/smp_rmb() pair
> would also work.
A release/acquire pair is cheap: I can send a follow-up later on.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2026-11-18 22:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 22:06 [PATCH net 0/7] mptcp: misc fixes for v7.4-rc4 Matthieu Baerts (NGI0)
2026-11-16 22:06 ` [PATCH net 1/7] mptcp: do not use a raised snd_wnd for the send window Matthieu Baerts (NGI0)
2026-11-16 22:06 ` [PATCH net 2/7] mptcp: push pending data after a sendmsg copy fault Matthieu Baerts (NGI0)
2026-11-17 22:29 ` netdev-bot+sashiko
2026-11-18 22:01 ` Matthieu Baerts
2026-11-16 22:06 ` [PATCH net 3/7] mptcp: use sk instead of casting msk in check_fully_established() Matthieu Baerts (NGI0)
2026-11-16 22:06 ` [PATCH net 4/7] mptcp: push queued data on passive TFO subflows becoming established Matthieu Baerts (NGI0)
2026-11-17 22:29 ` netdev-bot+sashiko
2026-11-18 22:02 ` Matthieu Baerts
2026-11-16 22:06 ` [PATCH net 5/7] mptcp: push queued data on subflows falling back at the handshake Matthieu Baerts (NGI0)
2026-11-17 22:29 ` netdev-bot+sashiko
2026-11-18 22:02 ` Matthieu Baerts
2026-11-16 22:06 ` [PATCH net 6/7] mptcp: don't send a FIN before the pending data on fallback Matthieu Baerts (NGI0)
2026-11-17 22:29 ` netdev-bot+sashiko
2026-11-18 22:03 ` Matthieu Baerts [this message]
2026-11-16 22:06 ` [PATCH net 7/7] mptcp: fix dummy mapping of overlapping segments Matthieu Baerts (NGI0)
2026-11-17 22:29 ` netdev-bot+sashiko
2026-11-18 22:04 ` Matthieu Baerts
2026-11-18 22:05 ` [PATCH net 0/7] mptcp: misc fixes for v7.4-rc4 Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a25b7f89-88e4-419e-83cc-83c5d1776421@kernel.org \
--to=matttbe@kernel.org \
--cc=davem@davemloft.net \
--cc=dmytro@shytyi.net \
--cc=edumazet@kernel.org \
--cc=fw@strlen.de \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=mason@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox