From: Alexei Starovoitov <ast@fb.com>
To: Song Liu <songliubraving@fb.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"ast@kernel.org" <ast@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <Kernel-team@fb.com>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
Teng Qin <qinteng@fb.com>
Subject: Re: [PATCH bpf-next v4 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address
Date: Mon, 12 Mar 2018 14:31:46 -0700 [thread overview]
Message-ID: <a7ac3a74-959f-af35-81ce-a8c05be29b68@fb.com> (raw)
In-Reply-To: <664505EF-F681-4641-B49A-6CF4F5CFB5C8@fb.com>
On 3/12/18 2:12 PM, Song Liu wrote:
>
>> On Mar 12, 2018, at 2:00 PM, Alexei Starovoitov <ast@fb.com> wrote:
>>
>> On 3/12/18 1:39 PM, Song Liu wrote:
>>> + page = find_get_page(vma->vm_file->f_mapping, 0);
>>
>> did you test it with config_debug_atomic_sleep ?
>> it should have complained...
>
> Yeah, I have CONFIG_DEBUG_ATOMIC_SLEEP=y.
>
> I think find_get_page() will not sleep. The variation find_get_page_flags()
> may sleep with flag FGP_CREAT.
I see. gfp_mask == 0 and no locks. should work indeed.
curious how perf report looks like for heavy bpf_get_stackid() usage?
next prev parent reply other threads:[~2018-03-12 21:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 20:39 [PATCH bpf-next v4 0/2] bpf stackmap with build_id+offset Song Liu
2018-03-12 20:39 ` [PATCH bpf-next v4 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address Song Liu
2018-03-12 21:00 ` Alexei Starovoitov
2018-03-12 21:12 ` Song Liu
2018-03-12 21:31 ` Alexei Starovoitov [this message]
2018-03-12 22:47 ` Song Liu
2018-03-13 21:31 ` Song Liu
2018-03-12 22:01 ` Peter Zijlstra
2018-04-24 0:06 ` Yonghong Song
2018-03-13 9:53 ` kbuild test robot
2018-03-13 9:53 ` [PATCH] bpf: fix semicolon.cocci warnings kbuild test robot
2018-03-12 20:39 ` [PATCH bpf-next v4 2/2] bpf: add selftest for stackmap with BPF_F_STACK_BUILD_ID Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7ac3a74-959f-af35-81ce-a8c05be29b68@fb.com \
--to=ast@fb.com \
--cc=Kernel-team@fb.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=hannes@cmpxchg.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=qinteng@fb.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox