From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Parav Pandit <parav@mellanox.com>,
jiri@mellanox.com, davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] devlink: Fix list access without lock while reading region
Date: Tue, 12 Feb 2019 12:01:13 +0300 [thread overview]
Message-ID: <a8f3f707-bb7a-0cb3-201f-6fcc06169677@cogentembedded.com> (raw)
In-Reply-To: <1549955377-15828-1-git-send-email-parav@mellanox.com>
Hello!
On 12.02.2019 10:09, Parav Pandit wrote:
> While finding the devlink device during region reading,
> devlink device list is accessed and devlink device is
> returned without holding a lock. This could lead to user-after-free
Use-after-free, perhaps?
> accesses.
>
> While at it, add lockdep assert to ensure that all future callers hold
> the lock when calling devlink_get_from_attrs().
>
> Fixes: 4e54795a27f5 ("devlink: Add support for region snapshot read command")
> Signed-off-by: Parav Pandit <parav@mellanox.com>
> Acked-by: Jiri Pirko <jiri@mellanox.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2019-02-12 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 7:09 [PATCH net-next 2/2] devlink: Fix list access without lock while reading region Parav Pandit
2019-02-12 9:01 ` Sergei Shtylyov [this message]
2019-02-12 16:04 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8f3f707-bb7a-0cb3-201f-6fcc06169677@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=parav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox