From: David Ahern <dsahern@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>,
Michael Chan <michael.chan@broadcom.com>,
Parav Pandit <parav@nvidia.com>
Cc: aelior@marvell.com, skalluru@marvell.com, manishc@marvell.com,
netdev@vger.kernel.org, edumazet@google.com, davem@davemloft.net,
kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net-next] tcp: Make GRO completion function inline
Date: Mon, 3 Jul 2023 11:29:56 -0600 [thread overview]
Message-ID: <a9d7579c-f717-bfea-89c9-cf13b9b79a86@kernel.org> (raw)
In-Reply-To: <f25406bd-71b5-79e4-80f7-66c345341504@intel.com>
On 7/3/23 10:51 AM, Alexander Lobakin wrote:
> Why is this needed then if it gives nothing? :D
It is a question I asked. There are a fair number of trivial sk_buff
functions called in the datapath (e.g., skb_add_rx_frag is another).
Function calls are not free, so inlining them should *collectively*
provide measurable performance bumps as line rates and packet rates
increase.
prev parent reply other threads:[~2023-07-03 17:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-11 14:07 [PATCH net-next] tcp: Make GRO completion function inline Parav Pandit
2023-07-01 23:09 ` Michael Chan
2023-07-03 16:51 ` Alexander Lobakin
2023-07-03 17:00 ` Michael Chan
2023-07-03 17:29 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9d7579c-f717-bfea-89c9-cf13b9b79a86@kernel.org \
--to=dsahern@kernel.org \
--cc=aelior@marvell.com \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=manishc@marvell.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=skalluru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox