Re: [PATCH net-next] tcp: Make GRO completion function inline

[Alexander Lobakin <aleksander.lobakin@intel.com>]

From: Michael Chan <michael.chan@broadcom.com>
Date: Sat, 1 Jul 2023 16:09:53 -0700

> On Sun, Jun 11, 2023 at 7:08 AM Parav Pandit <parav@nvidia.com> wrote:
>>
>> At 100G link speed, with 1500 MTU, at 8.2 mpps, if device does GRO for
>> 64K message size, currently it results in ~190k calls to
>> tcp_gro_complete() in data path.
>>
>> Inline this small routine to avoid above number of function calls.
>>
>> Suggested-by: David Ahern <dsahern@kernel.org>
>> Signed-off-by: Parav Pandit <parav@nvidia.com>
>>
>> ---
>> This patch is untested as I do not have the any of the 3 hw devices
>> calling this routine.
>>
>> qede, bnxt and bnx2x maintainers,
>>
>> Can you please verify it with your devices if it reduces cpu
>> utilization marginally or it stays same or has some side effects?
>>
>> ---
> 
> Sorry for the delay.  It works fine on bnxt NICs running hardware GRO.
> No noticeable changes in throughput or CPU utilization running simple
> netperf.  Thanks.
> 
> Tested-by: Michael Chan <michael.chan@broadcom.com>
> Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Why is this needed then if it gives nothing? :D

Thanks,
Olek