[PATCH net-next] eth: mlx5: remove Kconfig co-dependency with VXLAN

[PATCH net-next] eth: mlx5: remove Kconfig co-dependency with VXLAN

[Jakub Kicinski]

mlx5 has a Kconfig co-dependency on VXLAN, even tho it doesn't
call any VXLAN function (unlike mlxsw). Perhaps this dates back
to very old days when tunnel ports were fetched directly from
VXLAN.

Remove the dependency to allow MLX5=y + VXLAN=m kernel configs.
But still avoid compiling in the lib/vxlan code if VXLAN=n.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: saeedm@nvidia.com
CC: leon@kernel.org
CC: tariqt@nvidia.com
CC: mbloch@nvidia.com
---
 drivers/net/ethernet/mellanox/mlx5/core/Kconfig  | 1 -
 drivers/net/ethernet/mellanox/mlx5/core/Makefile | 4 +++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
index 6ec7d6e0181d..8ef2ac2060ba 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
+++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
@@ -8,7 +8,6 @@ config MLX5_CORE
 	depends on PCI
 	select AUXILIARY_BUS
 	select NET_DEVLINK
-	depends on VXLAN || !VXLAN
 	depends on MLXFW || !MLXFW
 	depends on PTP_1588_CLOCK_OPTIONAL
 	depends on PCI_HYPERV_INTERFACE || !PCI_HYPERV_INTERFACE
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Makefile b/drivers/net/ethernet/mellanox/mlx5/core/Makefile
index a253c73db9e5..206223ce63a8 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/Makefile
+++ b/drivers/net/ethernet/mellanox/mlx5/core/Makefile
@@ -85,7 +85,9 @@ mlx5_core-$(CONFIG_MLX5_BRIDGE)    += esw/bridge.o esw/bridge_mcast.o esw/bridge
 
 mlx5_core-$(CONFIG_HWMON)          += hwmon.o
 mlx5_core-$(CONFIG_MLX5_MPFS)      += lib/mpfs.o
-mlx5_core-$(CONFIG_VXLAN)          += lib/vxlan.o
+ifneq ($(CONFIG_VXLAN),)
+	mlx5_core-y		   += lib/vxlan.o
+endif
 mlx5_core-$(CONFIG_PTP_1588_CLOCK) += lib/clock.o
 mlx5_core-$(CONFIG_PCI_HYPERV_INTERFACE) += lib/hv.o lib/hv_vhca.o
 
-- 
2.51.0

Re: [PATCH net-next] eth: mlx5: remove Kconfig co-dependency with VXLAN

[Saeed Mahameed]

On 27 Aug 16:43, Jakub Kicinski wrote:
>mlx5 has a Kconfig co-dependency on VXLAN, even tho it doesn't
>call any VXLAN function (unlike mlxsw). Perhaps this dates back
>to very old days when tunnel ports were fetched directly from
>VXLAN.
>
>Remove the dependency to allow MLX5=y + VXLAN=m kernel configs.
>But still avoid compiling in the lib/vxlan code if VXLAN=n.
>
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Nice improvement, Thanks!

Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>

Re: [PATCH net-next] eth: mlx5: remove Kconfig co-dependency with VXLAN

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 27 Aug 2025 16:43:19 -0700 you wrote:
> mlx5 has a Kconfig co-dependency on VXLAN, even tho it doesn't
> call any VXLAN function (unlike mlxsw). Perhaps this dates back
> to very old days when tunnel ports were fetched directly from
> VXLAN.
> 
> Remove the dependency to allow MLX5=y + VXLAN=m kernel configs.
> But still avoid compiling in the lib/vxlan code if VXLAN=n.
> 
> [...]

Here is the summary with links:
  - [net-next] eth: mlx5: remove Kconfig co-dependency with VXLAN
    https://git.kernel.org/netdev/net-next/c/15d157c3ad01

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html