From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH v1 0/7] ptp: ocp: A fix and refactoring
Date: Tue, 18 Nov 2025 20:37:20 +0200 [thread overview]
Message-ID: <aRy84Cm8Wo84SIpo@ashevche-desk.local> (raw)
On Wed, Nov 12, 2025 at 03:27:14PM +0000, Vadim Fedorenko wrote:
> On 11/11/2025 16:52, Andy Shevchenko wrote:
>
> > ptp: ocp: Sort headers alphabetically
> > ptp: ocp: don't use "proxy" headers
> I don't see benefits of these 2 patches, what's the reason?
I may give these reasons:
1. Makes clear what headers are in use (avoids dups and improves long-term
maintenance experience).
2. Makes sure we don't "include everything". This might (slightly) improve
the module build time, but also shows that we use what we use.
There are patches in the history of the Linux kernel for both scenarios
in C files (yes, for the h files such a change is much more important).
...
TBH, the driver is written in a bad style, it has so-o-o many issues,
I even don't know where to start... Oh, wait.
--
With Best Regards,
Andy Shevchenko
next reply other threads:[~2025-11-18 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 18:37 Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-11-11 16:52 [PATCH v1 0/7] ptp: ocp: A fix and refactoring Andy Shevchenko
2025-11-12 15:27 ` Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRy84Cm8Wo84SIpo@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox