Re: [PATCH v1 0/7] ptp: ocp: A fix and refactoring

Re: [PATCH v1 0/7] ptp: ocp: A fix and refactoring

[Andy Shevchenko]

On Wed, Nov 12, 2025 at 03:27:14PM +0000, Vadim Fedorenko wrote:
> On 11/11/2025 16:52, Andy Shevchenko wrote:
> 
> >    ptp: ocp: Sort headers alphabetically
> >    ptp: ocp: don't use "proxy" headers
> I don't see benefits of these 2 patches, what's the reason?

I may give these reasons:

1. Makes clear what headers are in use (avoids dups and improves long-term
maintenance experience).

2. Makes sure we don't "include everything". This might (slightly) improve
the module build time, but also shows that we use what we use.

There are patches in the history of the Linux kernel for both scenarios
in C files (yes, for the h files such a change is much more important).

...

TBH, the driver is written in a bad style, it has so-o-o many issues,
I even don't know where to start... Oh, wait.

-- 
With Best Regards,
Andy Shevchenko

[PATCH v1 0/7] ptp: ocp: A fix and refactoring

[Andy Shevchenko]

Here is the fix for incorrect use of %ptT with the associated
refactoring and additional cleanups.

Note, %ptS, which is introduced in another series, doesn't fit
here, that's why this fix is separated from that series.

Andy Shevchenko (7):
  ptp: ocp: Refactor signal_show() and fix %ptT misuse
  ptp: ocp: Make ptp_ocp_unregister_ext() NULL-aware
  ptp: ocp: Refactor ptp_ocp_i2c_notifier_call()
  ptp: ocp: Apply standard pattern for cleaning up loop
  ptp: ocp: Reuse META's PCI vendor ID
  ptp: ocp: Sort headers alphabetically
  ptp: ocp: don't use "proxy" headers

 drivers/ptp/ptp_ocp.c | 128 +++++++++++++++++++++++-------------------
 1 file changed, 70 insertions(+), 58 deletions(-)

-- 
2.50.1

Re: [PATCH v1 0/7] ptp: ocp: A fix and refactoring

[Vadim Fedorenko]

On 11/11/2025 16:52, Andy Shevchenko wrote:

>    ptp: ocp: Sort headers alphabetically
>    ptp: ocp: don't use "proxy" headers
I don't see benefits of these 2 patches, what's the reason?