[PATCH net-next] vsock/test: add a final full barrier after run all tests

[PATCH net-next] vsock/test: add a final full barrier after run all tests

[Stefano Garzarella]

From: Stefano Garzarella <sgarzare@redhat.com>

If the last test fails, the other side still completes correctly,
which could lead to false positives.

Let's add a final barrier that ensures that the last test has finished
correctly on both sides, but also that the two sides agree on the
number of tests to be performed.

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
 tools/testing/vsock/util.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c
index d843643ced6b..9430ef5b8bc3 100644
--- a/tools/testing/vsock/util.c
+++ b/tools/testing/vsock/util.c
@@ -511,6 +511,18 @@ void run_tests(const struct test_case *test_cases,
 
 		printf("ok\n");
 	}
+
+	printf("All tests have been executed. Waiting other peer...");
+	fflush(stdout);
+
+	/*
+	 * Final full barrier, to ensure that all tests have been run and
+	 * that even the last one has been successful on both sides.
+	 */
+	control_writeln("COMPLETED");
+	control_expectln("COMPLETED");
+
+	printf("ok\n");
 }
 
 void list_tests(const struct test_case *test_cases)
-- 
2.52.0

Re: [PATCH net-next] vsock/test: add a final full barrier after run all tests

[Luigi Leonardi]

On Tue, Dec 23, 2025 at 05:22:10PM +0100, Stefano Garzarella wrote:
>From: Stefano Garzarella <sgarzare@redhat.com>
>
>If the last test fails, the other side still completes correctly,
>which could lead to false positives.
>
>Let's add a final barrier that ensures that the last test has finished
>correctly on both sides, but also that the two sides agree on the
>number of tests to be performed.
>
>Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
>---
> tools/testing/vsock/util.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
>diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c
>index d843643ced6b..9430ef5b8bc3 100644
>--- a/tools/testing/vsock/util.c
>+++ b/tools/testing/vsock/util.c
>@@ -511,6 +511,18 @@ void run_tests(const struct test_case *test_cases,
>
> 		printf("ok\n");
> 	}
>+
>+	printf("All tests have been executed. Waiting other peer...");
>+	fflush(stdout);
>+
>+	/*
>+	 * Final full barrier, to ensure that all tests have been run and
>+	 * that even the last one has been successful on both sides.
>+	 */
>+	control_writeln("COMPLETED");
>+	control_expectln("COMPLETED");
>+
>+	printf("ok\n");
> }
>
> void list_tests(const struct test_case *test_cases)
>-- 
>2.52.0
>

LGTM!

Reviewed-by: Luigi Leonardi <leonardi@redhat.com>

Re: [PATCH net-next] vsock/test: add a final full barrier after run all tests

[Paolo Abeni]

On 12/23/25 5:22 PM, Stefano Garzarella wrote:
> From: Stefano Garzarella <sgarzare@redhat.com>
> 
> If the last test fails, the other side still completes correctly,
> which could lead to false positives.
> 
> Let's add a final barrier that ensures that the last test has finished
> correctly on both sides, but also that the two sides agree on the
> number of tests to be performed.
> 
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>

Net-next is currently closed; still this looks material suitable for
'net', with a proper Fixes tag.

Please repost for net if you agree.

Thanks,

Paolo

Re: [PATCH net-next] vsock/test: add a final full barrier after run all tests

[Stefano Garzarella]

On Tue, Dec 30, 2025 at 12:08:44PM +0100, Paolo Abeni wrote:
>On 12/23/25 5:22 PM, Stefano Garzarella wrote:
>> From: Stefano Garzarella <sgarzare@redhat.com>
>>
>> If the last test fails, the other side still completes correctly,
>> which could lead to false positives.
>>
>> Let's add a final barrier that ensures that the last test has finished
>> correctly on both sides, but also that the two sides agree on the
>> number of tests to be performed.
>>
>> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
>
>Net-next is currently closed; still this looks material suitable for
>'net', with a proper Fixes tag.
>
>Please repost for net if you agree.

Sure, I'll repost for `net`.

Thanks,
Stefano