From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <sbhatta@marvell.com>, <edumazet@google.com>,
<andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>,
<sgoutham@marvell.com>, <sumang@marvell.com>, <pabeni@redhat.com>,
<davem@davemloft.net>, <linux-kernel@vger.kernel.org>
Subject: Re: [net-next,v5,06/13] octeontx2-af: npc: cn20k: Use common APIs
Date: Wed, 28 Jan 2026 09:01:02 +0530 [thread overview]
Message-ID: <aXmC9p4duz0uzV7Q@rkannoth-OptiPlex-7090> (raw)
In-Reply-To: <20260128022924.4152852-1-kuba@kernel.org>
On 2026-01-28 at 07:59:24, Jakub Kicinski (kuba@kernel.org) wrote:
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
>
> > + else
> > + keyx_cfg = mkex->keyx_cfg;
> >
> > /* Reserve last counter for MCAM RX miss action which is set to
> > * drop packet. This way we will know how many pkts didn't match
> > @@ -2080,7 +2169,6 @@ static void rvu_npc_setup_interfaces(struct rvu *rvu, int blkaddr)
> > mcam->counters.max--;
> > mcam->rx_miss_act_cntr = mcam->counters.max;
> ^^^^^^^^^^
>
> Was the removal of "goto skip_miss_cntr" intentional for cn20k? Previously,
> cn20k would skip the counter reservation here. Now cn20k reserves a counter
> via mcam->counters.max-- but never programs NPC_AF_INTFX_MISS_STAT_ACT (due
> to the "continue" later in the RX interface loop). This appears to waste
> one counter on cn20k.
ACK. cn20k does not use counters. Anyway i moved this under SoC cn20k check.
>
> > -skip_miss_cntr:
> > rx_kex = keyx_cfg[NIX_INTF_RX];
> > tx_kex = keyx_cfg[NIX_INTF_TX];
> >
next prev parent reply other threads:[~2026-01-28 3:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 12:32 [PATCH net-next v5 00/13] NPC HW block support for cn20k Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 01/13] octeontx2-af: npc: cn20k: Index management Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 02/13] octeontx2-af: npc: cn20k: KPM profile changes Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 03/13] octeontx2-af: npc: cn20k: Add default profile Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 04/13] octeontx2-af: npc: cn20k: MKEX profile support Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 05/13] octeontx2-af: npc: cn20k: Allocate default MCAM indexes Ratheesh Kannoth
2026-01-28 2:29 ` [net-next,v5,05/13] " Jakub Kicinski
2026-01-28 3:29 ` Ratheesh Kannoth
2026-01-29 2:11 ` Jakub Kicinski
2026-01-26 12:32 ` [PATCH net-next v5 06/13] octeontx2-af: npc: cn20k: Use common APIs Ratheesh Kannoth
2026-01-28 2:29 ` [net-next,v5,06/13] " Jakub Kicinski
2026-01-28 3:31 ` Ratheesh Kannoth [this message]
2026-01-26 12:32 ` [PATCH net-next v5 07/13] octeontx2-af: npc: cn20k: Prepare for new SoC Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 08/13] octeontx2-af: npc: cn20k: Add new mailboxes for CN20K silicon Ratheesh Kannoth
2026-01-28 2:29 ` [net-next,v5,08/13] " Jakub Kicinski
2026-01-28 3:31 ` Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 09/13] octeontx2-af: npc: cn20k: virtual index support Ratheesh Kannoth
2026-01-28 2:29 ` [net-next,v5,09/13] " Jakub Kicinski
2026-01-28 3:35 ` Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 10/13] octeontx2-af: npc: cn20k: Allocate MCAM entry for flow installation Ratheesh Kannoth
2026-01-28 2:29 ` [net-next,v5,10/13] " Jakub Kicinski
2026-01-28 3:36 ` Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 11/13] octeontx2-pf: cn20k: Add TC rules support Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 12/13] octeontx2-af: npc: cn20k: add debugfs support Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 13/13] octeontx2-af: npc: Use common structures Ratheesh Kannoth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXmC9p4duz0uzV7Q@rkannoth-OptiPlex-7090 \
--to=rkannoth@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox