Netdev List
 help / color / mirror / Atom feed
From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <sbhatta@marvell.com>, <edumazet@google.com>,
	<andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>,
	<sgoutham@marvell.com>, <sumang@marvell.com>, <pabeni@redhat.com>,
	<davem@davemloft.net>, <linux-kernel@vger.kernel.org>
Subject: Re: [net-next,v5,05/13] octeontx2-af: npc: cn20k: Allocate default MCAM indexes
Date: Wed, 28 Jan 2026 08:59:41 +0530	[thread overview]
Message-ID: <aXmCpZWl9JHk2bpC@rkannoth-OptiPlex-7090> (raw)
In-Reply-To: <20260128022921.4152787-1-kuba@kernel.org>

On 2026-01-28 at 07:59:21, Jakub Kicinski (kuba@kernel.org) wrote:
> > +chk_sanity:
> > +	dev_dbg(rvu->dev,
> > +		"%s: Default index for pcifunc=%#x, bcast=%u mcast=%u promise=%u ucast=%u cnt=%u\n",
>                                                                        ^^^^^^^
>
> Should "promise" be "promisc" here? This appears to be a typo in the debug
> message.
ACK.

>
>
> > +/**
> > + * enum npc_dft_rule_id - Default rule type
> > + *
> > + * Mcam default rule type.
> > + *
> > + * @NPC_DFT_RULE_START_ID:	Not used
> > + * @NPC_DFT_RULE_PROMISC_ID:	promiscuous rule
> > + * @NPC_DFT_RULE_MCAST_ID:	promiscuous rule
>                                 ^^^^^^^^^^^^^^^^

>
> Should this say "multicast rule" instead of "promiscuous rule"? It appears
>
ACK.

>
> > + * @NPC_DFT_RULE_BCAST_ID:	broadcast rule
> > + * @NPC_DFT_RULE_UCAST_ID:	unicast rule
> > + * @NPC_DFT_RULE_MAX_ID:	Maximum index.
> > + */
> --
> pw-bot: cr

  reply	other threads:[~2026-01-28  3:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 12:32 [PATCH net-next v5 00/13] NPC HW block support for cn20k Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 01/13] octeontx2-af: npc: cn20k: Index management Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 02/13] octeontx2-af: npc: cn20k: KPM profile changes Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 03/13] octeontx2-af: npc: cn20k: Add default profile Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 04/13] octeontx2-af: npc: cn20k: MKEX profile support Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 05/13] octeontx2-af: npc: cn20k: Allocate default MCAM indexes Ratheesh Kannoth
2026-01-28  2:29   ` [net-next,v5,05/13] " Jakub Kicinski
2026-01-28  3:29     ` Ratheesh Kannoth [this message]
2026-01-29  2:11       ` Jakub Kicinski
2026-01-26 12:32 ` [PATCH net-next v5 06/13] octeontx2-af: npc: cn20k: Use common APIs Ratheesh Kannoth
2026-01-28  2:29   ` [net-next,v5,06/13] " Jakub Kicinski
2026-01-28  3:31     ` Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 07/13] octeontx2-af: npc: cn20k: Prepare for new SoC Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 08/13] octeontx2-af: npc: cn20k: Add new mailboxes for CN20K silicon Ratheesh Kannoth
2026-01-28  2:29   ` [net-next,v5,08/13] " Jakub Kicinski
2026-01-28  3:31     ` Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 09/13] octeontx2-af: npc: cn20k: virtual index support Ratheesh Kannoth
2026-01-28  2:29   ` [net-next,v5,09/13] " Jakub Kicinski
2026-01-28  3:35     ` Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 10/13] octeontx2-af: npc: cn20k: Allocate MCAM entry for flow installation Ratheesh Kannoth
2026-01-28  2:29   ` [net-next,v5,10/13] " Jakub Kicinski
2026-01-28  3:36     ` Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 11/13] octeontx2-pf: cn20k: Add TC rules support Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 12/13] octeontx2-af: npc: cn20k: add debugfs support Ratheesh Kannoth
2026-01-26 12:32 ` [PATCH net-next v5 13/13] octeontx2-af: npc: Use common structures Ratheesh Kannoth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXmCpZWl9JHk2bpC@rkannoth-OptiPlex-7090 \
    --to=rkannoth@marvell.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    --cc=sumang@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox