Netdev List
 help / color / mirror / Atom feed
From: Nimrod Oren <noren@nvidia.com>
To: Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>
Cc: "Saeed Mahameed" <saeedm@nvidia.com>,
	"Tariq Toukan" <tariqt@nvidia.com>,
	"Mark Bloch" <mbloch@nvidia.com>,
	"Leon Romanovsky" <leon@kernel.org>,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"Eric Dumazet" <edumazet@kernel.org>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Gal Pressman" <gal@nvidia.com>,
	"Cosmin Ratiu" <cratiu@nvidia.com>,
	"Dragos Tatulea" <dtatulea@nvidia.com>,
	"Carolina Jubran" <cjubran@nvidia.com>,
	"Björn Töpel" <bjorn@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH net-next v4] net/mlx5e: advertise tcp-data-split support
Date: Tue, 17 Nov 2026 19:49:21 +0200	[thread overview]
Message-ID: <aa4a9b49-4f63-48e5-9c96-1cfef109d21d@nvidia.com> (raw)
In-Reply-To: <cc814750-79f5-4eef-9c9b-e7bda86acc78@gmail.com>

On 15/11/2026 22:59, Dimitri Daskalakis wrote:
> On 11/15/26 2:39 AM, Nimrod Oren wrote:
>> On 11/11/2026 19:05, Dimitri Daskalakis wrote:
>>> Changes in v4:
>>> - Nimrod and sashiko pointed out that not reporting DISABLED for
>>>   tcp-data-split makes the feature look unsupported. This conflicted
>>>   with my attempt to block users from setting DISABLED, locally sashiko
>>>   found several scenarios where ring changes would get blocked.
>>
>> Can you please share those scenarios?
>>
>> I think blocking 'disabled' was the right direction. Allowing it doesn't
>> give users anything new, only a way to pin HW-GRO off, at the cost of
>> another dependency between the two knobs in mlx5e_fix_features().
>>
>> We can still report 'disabled' when HW-GRO is supported but off.
> 
> I should have saved the review, I reapplied v3 and added an else to 
> disable tcp-data-split if the merge type is not SHAMPO, here's what sashiko
> reports.
> 
>  [Medium]
>  Does this reject a value that get_ringparam reports?
> 
>  When HW-GRO is off, mlx5e_ethtool_get_ringparam() reports DISABLED. That
>  is accurate, because SHAMPO is not in use. Before this patch,
>  "ethtool -G eth0 tcp-data-split off" was accepted in that state. Now it
>  fails with -EINVAL whatever the HW-GRO state is.
> 
>  This affects any netlink client that reads the rings config and writes
>  the same attributes back. The whole request fails, including any ring
>  size change sent with it. The changelog does not mention that existing
>  users of "off" will break.
> 
>  A narrower fix may be possible. mlx5e_fix_features() could clear
>  NETIF_F_GRO_HW when hds_config is DISABLED, like it already handles
>  ENABLED. That would also fix the mis-reporting and keep DISABLED usable.
> 
> Netlink users that call get then set with the received parameters will
> get a failure. This generally applies to users who save the current ring state,
> and try to revert back (via netlink or ethtool). A subsequent sashiko run
> highlighted the manual use case via ethtool.
> 
> I recall sashiko had more severe feedback, but those cases may have been
> from the incorrect feature updates I fixed here [1]. The feedback is technically
> correct, though I'm not sure how much it matters in practice. v4 implements the
> narrower fix sashiko suggests, so it works for users who write back stored ring state.
> 
> [1] https://patchwork.kernel.org/project/netdevbpf/patch/20261017005401.1582755-1-dimitri.daskalakis1@gmail.com/

Thanks,

I'm not sure the write-back scenario is worth worrying about. The
drivers/net selftests for example always restore to 'auto' first rather
than a saved value, which seems like the safest way to reset this knob.

Still, there may be some merit to the point that blocking 'disabled'
would break setting it while HW-GRO is off, which works today, even if
it's not a very useful flow.

IMO both approaches are acceptable: v4 as is, or blocking 'disabled' as
in v3 plus reporting it when HW-GRO is supported but off. You can keep
my tag if you go with the latter.

Reviewed-by: Nimrod Oren <noren@nvidia.com>


      reply	other threads:[~2026-11-17 17:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 17:05 [PATCH net-next v4] net/mlx5e: advertise tcp-data-split support Dimitri Daskalakis
2026-11-13  8:06 ` netdev-bot+sashiko
2026-11-13 17:59   ` Dimitri Daskalakis
2026-11-15 10:39 ` Nimrod Oren
2026-11-15 20:59   ` Dimitri Daskalakis
2026-11-17 17:49     ` Nimrod Oren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa4a9b49-4f63-48e5-9c96-1cfef109d21d@nvidia.com \
    --to=noren@nvidia.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bjorn@kernel.org \
    --cc=cjubran@nvidia.com \
    --cc=cratiu@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=dimitri.daskalakis1@gmail.com \
    --cc=dtatulea@nvidia.com \
    --cc=edumazet@kernel.org \
    --cc=gal@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox