From: Daniel Borkmann <daniel@iogearbox.net>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
alexei.starovoitov@gmail.com
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com,
bpf@vger.kernel.org, jiri@resnulli.us
Subject: Re: [PATCH bpf-next] Revert "selftests: bpf: Don't try to read files without read permission"
Date: Fri, 1 Nov 2019 13:16:33 +0100 [thread overview]
Message-ID: <ab2db974-9754-1804-caa8-402ad9e8cb50@iogearbox.net> (raw)
In-Reply-To: <20191101005127.1355-1-jakub.kicinski@netronome.com>
On 11/1/19 1:51 AM, Jakub Kicinski wrote:
> This reverts commit 5bc60de50dfe ("selftests: bpf: Don't try to read
> files without read permission").
>
> Quoted commit does not work at all, and was never tested.
> Script requires root permissions (and tests for them)
> and os.access() will always return true for root.
>
> The correct fix is needed in the bpf tree, so let's just
> revert and save ourselves the merge conflict.
>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Applied, thanks!
prev parent reply other threads:[~2019-11-01 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 0:51 [PATCH bpf-next] Revert "selftests: bpf: Don't try to read files without read permission" Jakub Kicinski
2019-11-01 0:56 ` Alexei Starovoitov
2019-11-01 1:28 ` [oss-drivers] " Jakub Kicinski
2019-11-01 6:38 ` Jiri Pirko
2019-11-01 12:16 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab2db974-9754-1804-caa8-402ad9e8cb50@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox