From: Bastien Curutchet <bastien.curutchet@bootlin.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Woojung Huh" <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, "Andrew Lunn" <andrew@lunn.ch>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
"Richard Cochran" <richardcochran@gmail.com>,
"Pascal Eberhard" <pascal.eberhard@se.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Tristram Ha" <tristram.ha@microchip.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Vladimir Oltean" <vladimir.oltean@nxp.com>
Subject: Re: [PATCH net-next v2 1/8] net: dsa: microchip: don't reset on shutdown or driver removal
Date: Wed, 20 May 2026 08:23:20 +0200 [thread overview]
Message-ID: <ab7cfbf2-2491-4a18-b0fe-e245dc48b761@bootlin.com> (raw)
In-Reply-To: <20260519191006.01f83aed@kernel.org>
Hi Jakub,
On 5/20/26 4:10 AM, Jakub Kicinski wrote:
> On Fri, 15 May 2026 10:38:36 +0200 Bastien Curutchet wrote:
>> @@ -4170,16 +4170,15 @@ int ksz_set_wol(struct dsa_switch *ds, int port,
>> * the wol_enabled flag accordingly to reflect whether WoL is active on any
>> * port.
>> */
>> -static void ksz_wol_pre_shutdown(struct ksz_device *dev, bool *wol_enabled)
>> +static void ksz_wol_pre_shutdown(struct ksz_device *dev)
>
> this needs a kdoc update, did I not report it on v1?
> Maybe I forgot. scripts/kernel-doc is buggy, unfortunately
> and doesn't catch it. The fix is on the way.
Ok, I'll fix it in v3. I don't think that you reported it on v1.
Best regards,
Bastien
next prev parent reply other threads:[~2026-05-20 6:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 8:38 [PATCH net-next v2 0/8] net: dsa: microchip: Remove unnecessary ksz_dev_ops callbacks Bastien Curutchet
2026-05-15 8:38 ` [PATCH net-next v2 1/8] net: dsa: microchip: don't reset on shutdown or driver removal Bastien Curutchet
2026-05-20 2:10 ` Jakub Kicinski
2026-05-20 6:23 ` Bastien Curutchet [this message]
2026-05-15 8:38 ` [PATCH net-next v2 2/8] net: dsa: microchip: bypass dev_ops->setup() and teardown() for lan937x Bastien Curutchet
2026-05-15 8:38 ` [PATCH net-next v2 3/8] net: dsa: microchip: bypass dev_ops->setup() and teardown() for ksz9477 Bastien Curutchet
2026-05-15 8:38 ` [PATCH net-next v2 4/8] net: dsa: microchip: bypass dev_ops->setup() and teardown() for ksz8 Bastien Curutchet
2026-05-15 8:38 ` [PATCH net-next v2 5/8] net: dsa: microchip: remove dev_ops->setup() and teardown() Bastien Curutchet
2026-05-15 8:38 ` [PATCH net-next v2 6/8] net: dsa: microchip: bypass dev_ops for port_setup() Bastien Curutchet (Schneider Electric)
2026-05-15 8:38 ` [PATCH net-next v2 7/8] net: dsa: microchip: call DSA's phy_{read/write} to do mdio {read/write} Bastien Curutchet (Schneider Electric)
2026-05-15 8:38 ` [PATCH net-next v2 8/8] net: dsa: microchip: bypass dev_ops for phy_read()/phy_write() Bastien Curutchet (Schneider Electric)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab7cfbf2-2491-4a18-b0fe-e245dc48b761@bootlin.com \
--to=bastien.curutchet@bootlin.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pascal.eberhard@se.com \
--cc=richardcochran@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tristram.ha@microchip.com \
--cc=vladimir.oltean@nxp.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox