* [PATCH net] sfc: fix error code in efx_devlink_info_running_versions()
@ 2026-04-25 9:09 Dan Carpenter
2026-04-28 13:08 ` Simon Horman
2026-04-28 13:36 ` Edward Cree
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2026-04-25 9:09 UTC (permalink / raw)
To: Alejandro Lucero
Cc: Edward Cree, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Martin Habets, Jiri Pirko, netdev,
linux-net-drivers, linux-kernel, kernel-janitors
Return -EINVAL if efx_mcdi_rpc() doesn't return enough space.
Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/net/ethernet/sfc/efx_devlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
index d842c60dfc10..45f412bb9b5d 100644
--- a/drivers/net/ethernet/sfc/efx_devlink.c
+++ b/drivers/net/ethernet/sfc/efx_devlink.c
@@ -531,7 +531,7 @@ static int efx_devlink_info_running_versions(struct efx_nic *efx,
if (rc || outlength < MC_CMD_GET_VERSION_OUT_LEN) {
netif_err(efx, drv, efx->net_dev,
"mcdi MC_CMD_GET_VERSION failed\n");
- return rc;
+ return rc ?: -EINVAL;
}
/* Handle previous output */
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] sfc: fix error code in efx_devlink_info_running_versions()
2026-04-25 9:09 [PATCH net] sfc: fix error code in efx_devlink_info_running_versions() Dan Carpenter
@ 2026-04-28 13:08 ` Simon Horman
2026-04-28 13:36 ` Edward Cree
1 sibling, 0 replies; 4+ messages in thread
From: Simon Horman @ 2026-04-28 13:08 UTC (permalink / raw)
To: Dan Carpenter
Cc: Alejandro Lucero, Edward Cree, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Martin Habets,
Jiri Pirko, netdev, linux-net-drivers, linux-kernel,
kernel-janitors
On Sat, Apr 25, 2026 at 12:09:32PM +0300, Dan Carpenter wrote:
> Return -EINVAL if efx_mcdi_rpc() doesn't return enough space.
>
> Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] sfc: fix error code in efx_devlink_info_running_versions()
2026-04-25 9:09 [PATCH net] sfc: fix error code in efx_devlink_info_running_versions() Dan Carpenter
2026-04-28 13:08 ` Simon Horman
@ 2026-04-28 13:36 ` Edward Cree
2026-04-28 13:49 ` Dan Carpenter
1 sibling, 1 reply; 4+ messages in thread
From: Edward Cree @ 2026-04-28 13:36 UTC (permalink / raw)
To: Dan Carpenter, Alejandro Lucero
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Martin Habets, Jiri Pirko, netdev, linux-net-drivers,
linux-kernel, kernel-janitors
On 25/04/2026 10:09, Dan Carpenter wrote:
> Return -EINVAL if efx_mcdi_rpc() doesn't return enough space.
>
> Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> drivers/net/ethernet/sfc/efx_devlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
> index d842c60dfc10..45f412bb9b5d 100644
> --- a/drivers/net/ethernet/sfc/efx_devlink.c
> +++ b/drivers/net/ethernet/sfc/efx_devlink.c
> @@ -531,7 +531,7 @@ static int efx_devlink_info_running_versions(struct efx_nic *efx,
> if (rc || outlength < MC_CMD_GET_VERSION_OUT_LEN) {
> netif_err(efx, drv, efx->net_dev,
> "mcdi MC_CMD_GET_VERSION failed\n");
> - return rc;
> + return rc ?: -EINVAL;
> }
>
> /* Handle previous output */
Usual practice in sfc is to use -EIO for 'MC response was too short'; it
signifies misbehaviour from the hardware, not any invalid input argument
as -EINVAL would suggest.
Other than that, looks fine.
-ed
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] sfc: fix error code in efx_devlink_info_running_versions()
2026-04-28 13:36 ` Edward Cree
@ 2026-04-28 13:49 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2026-04-28 13:49 UTC (permalink / raw)
To: Edward Cree
Cc: Alejandro Lucero, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Martin Habets, Jiri Pirko, netdev,
linux-net-drivers, linux-kernel, kernel-janitors
On Tue, Apr 28, 2026 at 02:36:55PM +0100, Edward Cree wrote:
> On 25/04/2026 10:09, Dan Carpenter wrote:
> > Return -EINVAL if efx_mcdi_rpc() doesn't return enough space.
> >
> > Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> > ---
> > drivers/net/ethernet/sfc/efx_devlink.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
> > index d842c60dfc10..45f412bb9b5d 100644
> > --- a/drivers/net/ethernet/sfc/efx_devlink.c
> > +++ b/drivers/net/ethernet/sfc/efx_devlink.c
> > @@ -531,7 +531,7 @@ static int efx_devlink_info_running_versions(struct efx_nic *efx,
> > if (rc || outlength < MC_CMD_GET_VERSION_OUT_LEN) {
> > netif_err(efx, drv, efx->net_dev,
> > "mcdi MC_CMD_GET_VERSION failed\n");
> > - return rc;
> > + return rc ?: -EINVAL;
> > }
> >
> > /* Handle previous output */
>
> Usual practice in sfc is to use -EIO for 'MC response was too short'; it
> signifies misbehaviour from the hardware, not any invalid input argument
> as -EINVAL would suggest.
> Other than that, looks fine.
Sure, I'll send a v2.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-04-28 13:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-25 9:09 [PATCH net] sfc: fix error code in efx_devlink_info_running_versions() Dan Carpenter
2026-04-28 13:08 ` Simon Horman
2026-04-28 13:36 ` Edward Cree
2026-04-28 13:49 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox