From: Steffen Klassert <steffen.klassert@secunet.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Miller <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH 0/8] pull request (net): ipsec 2026-05-05
Date: Thu, 7 May 2026 07:54:04 +0200 [thread overview]
Message-ID: <afwo_DsMkYzL2AG9@secunet.com> (raw)
In-Reply-To: <20260506165149.12e30102@kernel.org>
On Wed, May 06, 2026 at 04:51:49PM -0700, Jakub Kicinski wrote:
> On Wed, 6 May 2026 16:50:35 -0700 Jakub Kicinski wrote:
> > On Tue, 5 May 2026 15:22:56 +0200 Steffen Klassert wrote:
> > > 5. Harden __xfrm_state_delete() against repeated or inconsistent unhashing
> > > of state list nodes by keying the removal on actual list membership and
> > > using delete-and-init helpers. From Michal Kosiorek.
> >
> > Sashiko seems to have extra comments for this but I suspect follow up
> > is the way to go there.
>
> I should have made it clear - Claude-shiko:
>
> https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260505132326.1362733-4-steffen.klassert@secunet.com
I think the races Sashiko reveals here don't exist. __xfrm_state_delete()
is always called with the xfrm_state lock held, so there can't be a
second __xfrm_state_delete() on the same xfrm_state.
prev parent reply other threads:[~2026-05-07 5:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 13:22 [PATCH 0/8] pull request (net): ipsec 2026-05-05 Steffen Klassert
2026-05-05 13:22 ` [PATCH 1/8] ipv6: xfrm6: release dst on error in xfrm6_rcv_encap() Steffen Klassert
2026-05-07 0:30 ` patchwork-bot+netdevbpf
2026-05-05 13:22 ` [PATCH 2/8] xfrm: ah: account for ESN high bits in async callbacks Steffen Klassert
2026-05-05 13:22 ` [PATCH 3/8] tools/selftests: Use a sensible timeout value for iperf3 client Steffen Klassert
2026-05-05 13:23 ` [PATCH 4/8] tools/selftests: Add a VXLAN+IPsec traffic test Steffen Klassert
2026-05-07 0:04 ` Jakub Kicinski
2026-05-07 0:23 ` Jakub Kicinski
2026-05-07 5:54 ` Steffen Klassert
2026-05-05 13:23 ` [PATCH 5/8] xfrm: Don't clobber inner headers when already set Steffen Klassert
2026-05-05 13:23 ` [PATCH 6/8] xfrm: provide message size for XFRM_MSG_MAPPING Steffen Klassert
2026-05-05 13:23 ` [PATCH 7/8] xfrm: defensively unhash xfrm_state lists in __xfrm_state_delete Steffen Klassert
2026-05-05 13:23 ` [PATCH 8/8] xfrm: esp: avoid in-place decrypt on shared skb frags Steffen Klassert
2026-05-06 23:50 ` [PATCH 0/8] pull request (net): ipsec 2026-05-05 Jakub Kicinski
2026-05-06 23:51 ` Jakub Kicinski
2026-05-07 5:54 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afwo_DsMkYzL2AG9@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox