* [PATCH net-next] xfrm: Reject excessive values for XFRMA_TFCPAD
@ 2026-05-13 16:50 David Ahern
2026-05-16 8:02 ` Steffen Klassert
0 siblings, 1 reply; 2+ messages in thread
From: David Ahern @ 2026-05-13 16:50 UTC (permalink / raw)
To: steffen.klassert, herbert; +Cc: edumazet, kuba, pabeni, netdev, David Ahern
From: David Ahern <dahern@nvidia.com>
tfcpad is a u32, but that full range is excessive for padding.
Limit it to max IP length (64k).
Signed-off-by: David Ahern <dahern@nvidia.com>
---
net/xfrm/xfrm_user.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
index 38a90e5ee3d9..e8c31633f4f1 100644
--- a/net/xfrm/xfrm_user.c
+++ b/net/xfrm/xfrm_user.c
@@ -937,8 +937,14 @@ static struct xfrm_state *xfrm_state_construct(struct net *net,
attrs[XFRMA_ALG_COMP], extack)))
goto error;
- if (attrs[XFRMA_TFCPAD])
+ if (attrs[XFRMA_TFCPAD]) {
x->tfcpad = nla_get_u32(attrs[XFRMA_TFCPAD]);
+ if (x->tfcpad > IP_MAX_MTU) {
+ NL_SET_ERR_MSG(extack, "Excessive TFC padding");
+ err = -EINVAL;
+ goto error;
+ }
+ }
xfrm_mark_get(attrs, &x->mark);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] xfrm: Reject excessive values for XFRMA_TFCPAD
2026-05-13 16:50 [PATCH net-next] xfrm: Reject excessive values for XFRMA_TFCPAD David Ahern
@ 2026-05-16 8:02 ` Steffen Klassert
0 siblings, 0 replies; 2+ messages in thread
From: Steffen Klassert @ 2026-05-16 8:02 UTC (permalink / raw)
To: David Ahern; +Cc: herbert, edumazet, kuba, pabeni, netdev, David Ahern
On Wed, May 13, 2026 at 10:50:24AM -0600, David Ahern wrote:
> From: David Ahern <dahern@nvidia.com>
>
> tfcpad is a u32, but that full range is excessive for padding.
> Limit it to max IP length (64k).
>
> Signed-off-by: David Ahern <dahern@nvidia.com>
Also applied, thanks a lot!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-16 8:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-13 16:50 [PATCH net-next] xfrm: Reject excessive values for XFRMA_TFCPAD David Ahern
2026-05-16 8:02 ` Steffen Klassert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox