From: Keith Busch <kbusch@kernel.org>
To: "Christian König" <christian.koenig@amd.com>
Cc: Zhiping Zhang <zhipingz@meta.com>, Jason Gunthorpe <jgg@ziepe.ca>,
Alex Williamson <alex@shazbot.org>,
Leon Romanovsky <leon@kernel.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Bjorn Helgaas <helgaas@kernel.org>,
kvm@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-pci@vger.kernel.org, netdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, Yochai Cohen <yochai@nvidia.com>,
Yishai Hadas <yishaih@nvidia.com>,
Linus Torvalds <torvalds@linuxfoundation.org>
Subject: Re: [PATCH v5 0/4] vfio/dma-buf: add TPH support for peer-to-peer access
Date: Fri, 29 May 2026 14:31:30 -0600 [thread overview]
Message-ID: <ahn3ovmkEq-Y-LKt@kbusch-mbp> (raw)
In-Reply-To: <8d9bb0b7-182d-4930-b683-d5d24da6b2ab@amd.com>
On Fri, May 29, 2026 at 09:36:00AM +0200, Christian König wrote:
> On 5/29/26 08:34, Zhiping Zhang wrote:
> ...
> > There's no in-tree vendor PF driver
>
> Well I have to admit it's a bit on the edge but this sentence is a show stopper.
>
> DMA-buf is an in kernel interface for buffer sharing between drivers and any change to it needs an in kernel driver as justification for the added complexity.
>
> > - the device is a Meta MTIA
> > accelerator managed entirely from userspace via VFIO passthrough.
>
> When you have a complete open source driver stack which utilizes VFIO passthrough as the interface to communicate with the kernel drivers then we can eventually talk about that.
>
> But as far as I can see without upstreaming or at least open sourcing the full stack to utilize this functionality it's a clear NAK to upstreaming this.
But the existing dmabuf for vfio-pci was accepted upstream without these
requirements. I see you had concerns about even that, but still Acked
under the same model that's propsed in this series:
https://lore.kernel.org/linux-pci/57b8876f-1399-4e4d-a44b-1177787aa17d@amd.com/
So with vfio-pci and mlx5 both in-tree dmabuf users, implementing and
consuming the callback, does this not satisfy the requirement? The
userspace-driven semantics are inherent to VFIO's design. I don't see
what additional value open sourcing the user-side provides for the
kernel-side review process.
next prev parent reply other threads:[~2026-05-29 20:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260526144401.1485788-1-zhipingz@meta.com>
2026-05-27 6:55 ` [PATCH v5 0/4] vfio/dma-buf: add TPH support for peer-to-peer access Christian König
2026-05-27 12:14 ` Jason Gunthorpe
2026-05-27 12:23 ` Christian König
2026-05-27 12:36 ` Jason Gunthorpe
2026-05-27 12:53 ` Christian König
2026-05-28 4:55 ` Zhiping Zhang
2026-05-28 7:46 ` Christian König
2026-05-29 6:34 ` Zhiping Zhang
2026-05-29 7:36 ` Christian König
2026-05-29 20:11 ` Jason Gunthorpe
2026-05-29 20:31 ` Keith Busch [this message]
[not found] ` <20260526144401.1485788-3-zhipingz@meta.com>
2026-05-27 6:57 ` [PATCH v5 2/4] dma-buf: add optional get_tph() callback Christian König
2026-05-27 17:03 ` Alex Williamson
[not found] ` <20260526144401.1485788-4-zhipingz@meta.com>
2026-05-27 18:06 ` [PATCH v5 3/4] vfio/pci: implement get_tph and DMA_BUF_TPH feature Alex Williamson
2026-05-28 5:34 ` Zhiping Zhang
[not found] ` <20260526144401.1485788-2-zhipingz@meta.com>
2026-05-27 20:53 ` [PATCH v5 1/4] PCI/TPH: expose the enabled TPH requester type Alex Williamson
2026-05-28 5:35 ` Zhiping Zhang
2026-05-28 8:04 ` fengchengwen
2026-05-29 6:41 ` Zhiping Zhang
[not found] ` <20260526144401.1485788-5-zhipingz@meta.com>
2026-05-27 19:00 ` [PATCH v5 4/4] RDMA/mlx5: get tph for p2p access when registering dma-buf mr Alex Williamson
2026-05-28 5:54 ` Zhiping Zhang
2026-05-27 22:55 ` Michael Gur
2026-05-28 6:07 ` Zhiping Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahn3ovmkEq-Y-LKt@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=alex@shazbot.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=helgaas@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kvm@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=torvalds@linuxfoundation.org \
--cc=yishaih@nvidia.com \
--cc=yochai@nvidia.com \
--cc=zhipingz@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox