Netdev List
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: michael.chan@broadcom.com, pavan.chebbi@broadcom.com,
	 stfomichev@gmail.com, kernel-team@meta.com,
	netdev@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: bnxt_en: suspicious RCU usage in bnxt_fw_reset_task() qdisc path in 7.1-rc6
Date: Wed, 3 Jun 2026 04:43:01 -0700	[thread overview]
Message-ID: <aiATI9qUfsL0jq1u@gmail.com> (raw)
In-Reply-To: <20260602105451.18a7390f@kernel.org>

On Tue, Jun 02, 2026 at 10:54:51AM -0700, Jakub Kicinski wrote:
> On Tue, 2 Jun 2026 08:33:31 -0700 Breno Leitao wrote:
> > This looks like a regression from:
> > 
> >   850d9248d2ea ("Revert "bnxt_en: bring back rtnl_lock() in the
> >                   bnxt_open() path"")
> > 
> > That revert dropped rtnl_lock() from the bnxt_open() paths and left
> > bnxt_fw_reset_task() holding only the instance lock around bnxt_open().
> > 
> > I can send a patch restoring rtnl_lock() around the bnxt_open() call in
> > bnxt_fw_reset_task() (re-taking rtnl before the instance lock, matching the
> > pre-revert code), but I wanted to report it first to make sure I am in the
> > right direction.
> 
> Yes, we need to revert the revert. Per my recent ethtool locking series
> netif_set_num_tx_queues needs rtnl_lock for now.

Ack and thanks for the direction. Do you want me to do it, or, is it
someone is already taking care of?

Thanks
--breno

  reply	other threads:[~2026-06-03 11:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 15:33 bnxt_en: suspicious RCU usage in bnxt_fw_reset_task() qdisc path in 7.1-rc6 Breno Leitao
2026-06-02 17:49 ` Stanislav Fomichev
2026-06-02 18:53   ` Stanislav Fomichev
2026-06-02 17:54 ` Jakub Kicinski
2026-06-03 11:43   ` Breno Leitao [this message]
2026-06-03 17:34     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiATI9qUfsL0jq1u@gmail.com \
    --to=leitao@debian.org \
    --cc=kernel-team@meta.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pavan.chebbi@broadcom.com \
    --cc=stfomichev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox