From: Stanislav Fomichev <sdf.kernel@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
michael.chan@broadcom.com, hkallweit1@gmail.com,
maxime.chevallier@bootlin.com, joshwash@google.com,
tariqt@nvidia.com, alexanderduyck@fb.com, willemb@google.com,
jacob.e.keller@intel.com, kory.maincent@bootlin.com,
jakub@cloudflare.com, nb@tipi-net.de
Subject: Re: [PATCH net-next v2 00/12] net: ethtool: let ops locked drivers run without rtnl_lock
Date: Mon, 8 Jun 2026 08:20:28 -0700 [thread overview]
Message-ID: <aibdpZV9mlUVsknb@devvm7509.cco0.facebook.com> (raw)
In-Reply-To: <20260605170952.52c00c2e@kernel.org>
On 06/05, Jakub Kicinski wrote:
> On Fri, 5 Jun 2026 15:48:48 -0700 Stanislav Fomichev wrote:
> > netdev_ops_lock_dereference name trips me a bit (_compat suffix would've been
> > more obvious), but I do agree with the reasoning about needing 'a' lock..
>
> Guess I hate long lines more than I hate inconsistencies.
>
> This:
>
> something = netdev_lock_ops_compat_dereference(&dev->something, dev);
>
> is uncomfortably close to 80 columns for me.
>
> I think the existing naming is as good as we'll get..
> If y'all disagree I can respin. I'll be sad but I'll respin :)
Nah, it's good. I feel like netdev_lock_ops_dereference is also already
a bit too long :-/
next prev parent reply other threads:[~2026-06-08 15:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 0:29 [PATCH net-next v2 00/12] net: ethtool: let ops locked drivers run without rtnl_lock Jakub Kicinski
2026-06-05 0:29 ` [PATCH net-next v2 01/12] net: ethtool: serialize broadcast notification sequence allocation Jakub Kicinski
2026-06-05 0:29 ` [PATCH net-next v2 02/12] net: ethtool: relax ethnl_req_get_phydev() locking assertion Jakub Kicinski
2026-06-05 0:29 ` [PATCH net-next v2 03/12] net: ethtool: make dev->hwprov ops-protected Jakub Kicinski
2026-06-05 0:29 ` [PATCH net-next v2 04/12] net: ethtool: optionally skip rtnl_lock on Netlink path for GET ops Jakub Kicinski
2026-06-05 0:29 ` [PATCH net-next v2 05/12] net: ethtool: optionally skip rtnl_lock on Netlink path for SET ops Jakub Kicinski
2026-06-08 22:15 ` Jacob Keller
2026-06-05 0:29 ` [PATCH net-next v2 06/12] net: ethtool: optionally skip rtnl_lock in cable test handlers Jakub Kicinski
2026-06-08 22:17 ` Jacob Keller
2026-06-05 0:29 ` [PATCH net-next v2 07/12] net: ethtool: optionally skip rtnl_lock in ethnl_tsinfo_dumpit() Jakub Kicinski
2026-06-05 0:29 ` [PATCH net-next v2 08/12] net: ethtool: optionally skip rtnl_lock in ethnl_act_module_fw_flash() Jakub Kicinski
2026-06-05 0:29 ` [PATCH net-next v2 09/12] net: ethtool: optionally skip rtnl_lock in RSS context handlers Jakub Kicinski
2026-06-05 0:29 ` [PATCH net-next v2 10/12] net: ethtool: ioctl: concentrate the locking Jakub Kicinski
2026-06-05 0:29 ` [PATCH net-next v2 11/12] net: ethtool: optionally skip rtnl_lock on IOCTL path Jakub Kicinski
2026-06-05 0:29 ` [PATCH net-next v2 12/12] docs: net: ethtool: document ops-locked drivers and op_needs_rtnl Jakub Kicinski
2026-06-05 22:48 ` [PATCH net-next v2 00/12] net: ethtool: let ops locked drivers run without rtnl_lock Stanislav Fomichev
2026-06-06 0:09 ` Jakub Kicinski
2026-06-08 15:20 ` Stanislav Fomichev [this message]
2026-06-08 22:04 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aibdpZV9mlUVsknb@devvm7509.cco0.facebook.com \
--to=sdf.kernel@gmail.com \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jakub@cloudflare.com \
--cc=joshwash@google.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=michael.chan@broadcom.com \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox