From: Breno Leitao <leitao@debian.org>
To: Satish Kharat <satishkh@cisco.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sesidhar Baddela <sebaddel@cisco.com>
Subject: Re: [PATCH net-next v11 02/12] enic: verify firmware supports V2 SR-IOV at probe time
Date: Mon, 6 Jul 2026 03:43:42 -0700 [thread overview]
Message-ID: <akuGzharvi_UDFNF@gmail.com> (raw)
In-Reply-To: <20260703-enic-sriov-v2-admin-channel-v2-v11-2-5b739f1fe9e5@cisco.com>
On Fri, Jul 03, 2026 at 11:08:51AM -0700, Satish Kharat wrote:
> During PF probe, query the firmware get-supported-feature interface
> to verify that the running firmware supports V2 SR-IOV. Firmware
> version 5.3(4.72) and later report VIC_FEATURE_SRIOV via
> CMD_GET_SUPP_FEATURE_VER. If the firmware does not support the
> feature, set vf_type to ENIC_VF_TYPE_NONE and log a warning so the
> admin knows a firmware upgrade is needed.
>
> V2 VFs are only ever enabled later through the sysfs .sriov_configure
> path (enic_sriov_configure()), which rejects ENIC_VF_TYPE_NONE before
> calling pci_enable_sriov(); there is no probe-time auto-enable, so
> firmware that lacks V2 support never exposes VFs.
>
> VIC_FEATURE_SRIOV is assigned the explicit value 4 to match the
> firmware ABI. Slot 3 (firmware's VIC_FEATURE_PTP) is reserved with
> a comment rather than a placeholder enum entry, since PTP is not
> used by the upstream driver.
>
> Suggested-by: Breno Leitao <leitao@debian.org>
> Signed-off-by: Satish Kharat <satishkh@cisco.com>
Reviewed-by: Breno Leitao <leitao@debian.org>
next prev parent reply other threads:[~2026-07-06 10:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 18:08 [PATCH net-next v11 00/12] enic: SR-IOV V2 admin channel and MBOX protocol Satish Kharat
2026-07-03 18:08 ` [PATCH net-next v11 01/12] enic: cancel tx_hang_reset work on device removal Satish Kharat
2026-07-03 18:08 ` [PATCH net-next v11 02/12] enic: verify firmware supports V2 SR-IOV at probe time Satish Kharat
2026-07-06 10:43 ` Breno Leitao [this message]
2026-07-03 18:08 ` [PATCH net-next v11 03/12] enic: add admin channel open and close for SR-IOV Satish Kharat
2026-07-03 18:08 ` [PATCH net-next v11 04/12] enic: add admin RQ buffer management Satish Kharat
2026-07-03 18:08 ` [PATCH net-next v11 05/12] enic: add admin CQ service with MSI-X interrupt and workqueue polling Satish Kharat
2026-07-03 18:08 ` [PATCH net-next v11 06/12] enic: define MBOX message types and header structures Satish Kharat
2026-07-03 18:08 ` [PATCH net-next v11 07/12] enic: add MBOX core send and receive for admin channel Satish Kharat
2026-07-03 18:08 ` [PATCH net-next v11 08/12] enic: add MBOX PF handlers for VF register and capability Satish Kharat
2026-07-03 18:08 ` [PATCH net-next v11 09/12] enic: add MBOX VF handlers for capability, register and link state Satish Kharat
2026-07-03 18:08 ` [PATCH net-next v11 10/12] enic: wire V2 SR-IOV enable with admin channel and MBOX Satish Kharat
2026-07-03 18:09 ` [PATCH net-next v11 11/12] enic: add V2 VF probe with admin channel and PF registration Satish Kharat
2026-07-03 18:09 ` [PATCH net-next v11 12/12] enic: re-establish V2 VF admin channel and PF registration after reset Satish Kharat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akuGzharvi_UDFNF@gmail.com \
--to=leitao@debian.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox