* [PATCH net-next v2] selftests/net: Skip srv6_end_dt46_l3vpn_test::host_vpn_tests if iproute2 too old
@ 2026-07-13 9:57 Alessio Faina
2026-07-15 9:15 ` Andrea Mayer
0 siblings, 1 reply; 3+ messages in thread
From: Alessio Faina @ 2026-07-13 9:57 UTC (permalink / raw)
To: netdev, linux-kselftest, Andrea Mayer
Cc: Alessio Faina, Po-Hsu Lin, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Simon Horman, Shuah Khan
In case iproute2 is older than version 5.14.0, released ~Sept 1, 2021,
the End.DT46 support is not available and the host_vpn_tests test contained
in the srv6_end_dt46_l3vpn_test.sh file is failing in some kernel backports.
This is the result of those tests:
################################################################################
TEST SECTION: SRv6 VPN connectivity test among hosts in the same tenant
################################################################################
TEST: IPv6 Hosts connectivity: hs-t100-1 -> hs-t100-2 (tenant 100) [ FAIL ]
TEST: IPv4 Hosts connectivity: hs-t100-1 -> hs-t100-2 (tenant 100) [ FAIL ]
TEST: IPv6 Hosts connectivity: hs-t100-2 -> hs-t100-1 (tenant 100) [ FAIL ]
TEST: IPv4 Hosts connectivity: hs-t100-2 -> hs-t100-1 (tenant 100) [ FAIL ]
TEST: IPv6 Hosts connectivity: hs-t200-3 -> hs-t200-4 (tenant 200) [ FAIL ]
TEST: IPv4 Hosts connectivity: hs-t200-3 -> hs-t200-4 (tenant 200) [ FAIL ]
TEST: IPv6 Hosts connectivity: hs-t200-4 -> hs-t200-3 (tenant 200) [ FAIL ]
TEST: IPv4 Hosts connectivity: hs-t200-4 -> hs-t200-3 (tenant 200) [ FAIL ]
To amend this, check the current running iproute2 supports the required
feature and, if not, just skip the test to avoid a failure.
Signed-off-by: Alessio Faina <alessio.faina@canonical.com>
---
v2:
- skip entire test suite if iproute2 is too old
v1: https://lore.kernel.org/netdev/20260708152745.2430714-1-alessio.faina@canonical.com/
.../testing/selftests/net/srv6_end_dt46_l3vpn_test.sh | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/tools/testing/selftests/net/srv6_end_dt46_l3vpn_test.sh b/tools/testing/selftests/net/srv6_end_dt46_l3vpn_test.sh
index a5e959a080bb..cd7ac03e3907 100755
--- a/tools/testing/selftests/net/srv6_end_dt46_l3vpn_test.sh
+++ b/tools/testing/selftests/net/srv6_end_dt46_l3vpn_test.sh
@@ -536,6 +536,14 @@ host_vpn_isolation_tests()
done
}
+test_iproute2_supp_or_ksft_skip()
+{
+ if ! ip route add help 2>&1 | grep -qo "End.DT46"; then
+ echo "SKIP: Missing SRv6 End.DT46 support in iproute2"
+ exit "${ksft_skip}"
+ fi
+}
+
if [ "$(id -u)" -ne 0 ];then
echo "SKIP: Need root privileges"
exit $ksft_skip
@@ -546,6 +554,8 @@ if [ ! -x "$(command -v ip)" ]; then
exit $ksft_skip
fi
+test_iproute2_supp_or_ksft_skip
+
modprobe vrf &>/dev/null
if [ ! -e /proc/sys/net/vrf/strict_mode ]; then
echo "SKIP: vrf sysctl does not exist"
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2] selftests/net: Skip srv6_end_dt46_l3vpn_test::host_vpn_tests if iproute2 too old
2026-07-13 9:57 [PATCH net-next v2] selftests/net: Skip srv6_end_dt46_l3vpn_test::host_vpn_tests if iproute2 too old Alessio Faina
@ 2026-07-15 9:15 ` Andrea Mayer
2026-07-15 12:04 ` Alessio Faina
0 siblings, 1 reply; 3+ messages in thread
From: Andrea Mayer @ 2026-07-15 9:15 UTC (permalink / raw)
To: Alessio Faina
Cc: netdev, linux-kselftest, Po-Hsu Lin, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman,
Shuah Khan, Andrea Mayer, stefano.salsano
On Mon, 13 Jul 2026 11:57:50 +0200
Alessio Faina <alessio.faina@canonical.com> wrote:
> In case iproute2 is older than version 5.14.0, released ~Sept 1, 2021,
> the End.DT46 support is not available and the host_vpn_tests test contained
> in the srv6_end_dt46_l3vpn_test.sh file is failing in some kernel backports.
> This is the result of those tests:
>
> ################################################################################
> TEST SECTION: SRv6 VPN connectivity test among hosts in the same tenant
> ################################################################################
>
> TEST: IPv6 Hosts connectivity: hs-t100-1 -> hs-t100-2 (tenant 100) [ FAIL ]
>
> TEST: IPv4 Hosts connectivity: hs-t100-1 -> hs-t100-2 (tenant 100) [ FAIL ]
>
> TEST: IPv6 Hosts connectivity: hs-t100-2 -> hs-t100-1 (tenant 100) [ FAIL ]
>
> TEST: IPv4 Hosts connectivity: hs-t100-2 -> hs-t100-1 (tenant 100) [ FAIL ]
>
> TEST: IPv6 Hosts connectivity: hs-t200-3 -> hs-t200-4 (tenant 200) [ FAIL ]
>
> TEST: IPv4 Hosts connectivity: hs-t200-3 -> hs-t200-4 (tenant 200) [ FAIL ]
>
> TEST: IPv6 Hosts connectivity: hs-t200-4 -> hs-t200-3 (tenant 200) [ FAIL ]
>
> TEST: IPv4 Hosts connectivity: hs-t200-4 -> hs-t200-3 (tenant 200) [ FAIL ]
>
> To amend this, check the current running iproute2 supports the required
> feature and, if not, just skip the test to avoid a failure.
>
>
> Signed-off-by: Alessio Faina <alessio.faina@canonical.com>
Hi Alessio,
Thanks for the v2, the code looks good to me.
One question: since the check now exits the entire script before setup(),
should the subject drop the "::host_vpn_tests" part?
just a nit: test_iproute2_supp_or_ksft_skip() uses spaces, but most of this
file uses tabs.
Ciao
Andrea
> ---
> v2:
> - skip entire test suite if iproute2 is too old
> v1: https://urldefense.com/v3/__https://lore.kernel.org/netdev/20260708152745.2430714-1-alessio.faina@canonical.com/__;!!O5Bi4QcV!CGb1HmTUSZ4JwCff0mVcoY_KnoHJmrGDAdGnPOEYWRVFi-J05H-ZtpLVZBNK12kwLaNmhzw7mrQw4M_eY5uuSft8PRuFHqU$
>
> .../testing/selftests/net/srv6_end_dt46_l3vpn_test.sh | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/tools/testing/selftests/net/srv6_end_dt46_l3vpn_test.sh b/tools/testing/selftests/net/srv6_end_dt46_l3vpn_test.sh
> index a5e959a080bb..cd7ac03e3907 100755
> --- a/tools/testing/selftests/net/srv6_end_dt46_l3vpn_test.sh
> +++ b/tools/testing/selftests/net/srv6_end_dt46_l3vpn_test.sh
> @@ -536,6 +536,14 @@ host_vpn_isolation_tests()
> done
> }
>
> +test_iproute2_supp_or_ksft_skip()
> +{
> + if ! ip route add help 2>&1 | grep -qo "End.DT46"; then
> + echo "SKIP: Missing SRv6 End.DT46 support in iproute2"
> + exit "${ksft_skip}"
> + fi
> +}
> +
> if [ "$(id -u)" -ne 0 ];then
> echo "SKIP: Need root privileges"
> exit $ksft_skip
> @@ -546,6 +554,8 @@ if [ ! -x "$(command -v ip)" ]; then
> exit $ksft_skip
> fi
>
> +test_iproute2_supp_or_ksft_skip
> +
> modprobe vrf &>/dev/null
> if [ ! -e /proc/sys/net/vrf/strict_mode ]; then
> echo "SKIP: vrf sysctl does not exist"
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2] selftests/net: Skip srv6_end_dt46_l3vpn_test::host_vpn_tests if iproute2 too old
2026-07-15 9:15 ` Andrea Mayer
@ 2026-07-15 12:04 ` Alessio Faina
0 siblings, 0 replies; 3+ messages in thread
From: Alessio Faina @ 2026-07-15 12:04 UTC (permalink / raw)
To: Andrea Mayer
Cc: netdev, linux-kselftest, Po-Hsu Lin, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman,
Shuah Khan, stefano.salsano
On Wed, Jul 15, 2026 at 11:15:30AM +0200, Andrea Mayer wrote:
> On Mon, 13 Jul 2026 11:57:50 +0200
> Alessio Faina <alessio.faina@canonical.com> wrote:
>
> > In case iproute2 is older than version 5.14.0, released ~Sept 1, 2021,
> > the End.DT46 support is not available and the host_vpn_tests test contained
> > in the srv6_end_dt46_l3vpn_test.sh file is failing in some kernel backports.
> > This is the result of those tests:
> >
> > ################################################################################
> > TEST SECTION: SRv6 VPN connectivity test among hosts in the same tenant
> > ################################################################################
> >
> > TEST: IPv6 Hosts connectivity: hs-t100-1 -> hs-t100-2 (tenant 100) [ FAIL ]
> >
> > TEST: IPv4 Hosts connectivity: hs-t100-1 -> hs-t100-2 (tenant 100) [ FAIL ]
> >
> > TEST: IPv6 Hosts connectivity: hs-t100-2 -> hs-t100-1 (tenant 100) [ FAIL ]
> >
> > TEST: IPv4 Hosts connectivity: hs-t100-2 -> hs-t100-1 (tenant 100) [ FAIL ]
> >
> > TEST: IPv6 Hosts connectivity: hs-t200-3 -> hs-t200-4 (tenant 200) [ FAIL ]
> >
> > TEST: IPv4 Hosts connectivity: hs-t200-3 -> hs-t200-4 (tenant 200) [ FAIL ]
> >
> > TEST: IPv6 Hosts connectivity: hs-t200-4 -> hs-t200-3 (tenant 200) [ FAIL ]
> >
> > TEST: IPv4 Hosts connectivity: hs-t200-4 -> hs-t200-3 (tenant 200) [ FAIL ]
> >
> > To amend this, check the current running iproute2 supports the required
> > feature and, if not, just skip the test to avoid a failure.
> >
> >
> > Signed-off-by: Alessio Faina <alessio.faina@canonical.com>
>
>
> Hi Alessio,
>
> Thanks for the v2, the code looks good to me.
>
> One question: since the check now exits the entire script before setup(),
> should the subject drop the "::host_vpn_tests" part?
>
> just a nit: test_iproute2_supp_or_ksft_skip() uses spaces, but most of this
> file uses tabs.
>
> Ciao
> Andrea
>
> > ---
> > v2:
> > - skip entire test suite if iproute2 is too old
> > v1: https://urldefense.com/v3/__https://lore.kernel.org/netdev/20260708152745.2430714-1-alessio.faina@canonical.com/__;!!O5Bi4QcV!CGb1HmTUSZ4JwCff0mVcoY_KnoHJmrGDAdGnPOEYWRVFi-J05H-ZtpLVZBNK12kwLaNmhzw7mrQw4M_eY5uuSft8PRuFHqU$
> >
> > .../testing/selftests/net/srv6_end_dt46_l3vpn_test.sh | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/tools/testing/selftests/net/srv6_end_dt46_l3vpn_test.sh b/tools/testing/selftests/net/srv6_end_dt46_l3vpn_test.sh
> > index a5e959a080bb..cd7ac03e3907 100755
> > --- a/tools/testing/selftests/net/srv6_end_dt46_l3vpn_test.sh
> > +++ b/tools/testing/selftests/net/srv6_end_dt46_l3vpn_test.sh
> > @@ -536,6 +536,14 @@ host_vpn_isolation_tests()
> > done
> > }
> >
> > +test_iproute2_supp_or_ksft_skip()
> > +{
> > + if ! ip route add help 2>&1 | grep -qo "End.DT46"; then
> > + echo "SKIP: Missing SRv6 End.DT46 support in iproute2"
> > + exit "${ksft_skip}"
> > + fi
> > +}
> > +
> > if [ "$(id -u)" -ne 0 ];then
> > echo "SKIP: Need root privileges"
> > exit $ksft_skip
> > @@ -546,6 +554,8 @@ if [ ! -x "$(command -v ip)" ]; then
> > exit $ksft_skip
> > fi
> >
> > +test_iproute2_supp_or_ksft_skip
> > +
> > modprobe vrf &>/dev/null
> > if [ ! -e /proc/sys/net/vrf/strict_mode ]; then
> > echo "SKIP: vrf sysctl does not exist"
> > --
> > 2.43.0
> >
Hi Andrea,
Yeah, I agree with you, the subject should be updated as well, I didn't
think about it. I will update the subject and the indentation in a V3
soon.
Kind regards,
-Alessio
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-15 12:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-13 9:57 [PATCH net-next v2] selftests/net: Skip srv6_end_dt46_l3vpn_test::host_vpn_tests if iproute2 too old Alessio Faina
2026-07-15 9:15 ` Andrea Mayer
2026-07-15 12:04 ` Alessio Faina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox