From: Davide Libenzi <davidel@xmailserver.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Davide Libenzi <davidel@xmailserver.org>,
Alban Crequy <alban.crequy@collabora.co.uk>,
"David S. Miller" <davem@davemloft.net>,
Stephen Hemminger <shemminger@vyatta.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
netdev@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Pauli Nieminen <pauli.nieminen@collabora.co.uk>,
Rainer Weikusat <rweikusat@mssgmbh.com>
Subject: Re: [PATCH] af_unix: optimize unix_dgram_poll()
Date: Sat, 30 Oct 2010 10:45:37 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1010301042040.12598@davide-lnx1> (raw)
In-Reply-To: <1288432420.2680.933.camel@edumazet-laptop>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 740 bytes --]
On Sat, 30 Oct 2010, Eric Dumazet wrote:
> Le vendredi 29 octobre 2010 à 13:46 -0700, Davide Libenzi a écrit :
>
> > Also, why not using the existing wait->key instead of adding a poll2()?
>
> Indeed, if wait is not null, we have in wait->key the interest of
> poller. If a particular poll() function is expensive, it can test these
> bits.
>
> Thanks !
>
> Note: I chose the 'goto skip_write' to make this patch really obvious.
Plain agreement on th patch, and I understand the indent overflow
concerns, but why not ...
/*
* No write status requested, avoid expensive OUT tests.
*/
if (wait && !(wait->key & (POLLWRBAND | POLLWRNORM | POLLOUT)))
return mask
The write-test code is the last one we do anyway.
- Davide
next prev parent reply other threads:[~2010-10-30 17:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 18:18 [PATCH 0/1] RFC: poll/select performance on datagram sockets Alban Crequy
2010-10-29 18:21 ` [PATCH] " Alban Crequy
2010-10-29 19:27 ` [PATCH 0/1] RFC: " Eric Dumazet
2010-10-29 20:08 ` Davide Libenzi
2010-10-29 20:20 ` Eric Dumazet
2010-10-29 20:46 ` Davide Libenzi
2010-10-29 21:05 ` Eric Dumazet
2010-10-29 21:57 ` Davide Libenzi
2010-10-29 22:08 ` Eric Dumazet
2010-10-30 9:53 ` [PATCH] af_unix: optimize unix_dgram_poll() Eric Dumazet
2010-10-30 17:45 ` Davide Libenzi [this message]
2010-10-29 20:20 ` [PATCH 0/1] RFC: poll/select performance on datagram sockets Jesper Juhl
2010-10-29 20:40 ` David Miller
2010-10-29 20:45 ` Eric Dumazet
2010-10-30 6:44 ` [PATCH] af_unix: unix_write_space() use keyed wakeups Eric Dumazet
2010-10-30 15:03 ` Davide Libenzi
2010-11-08 21:44 ` David Miller
2010-10-30 21:36 ` Alban Crequy
[not found] ` <1290554876.2158.5.camel@Nokia-N900-51-1>
2010-11-24 0:20 ` Alban Crequy
2010-11-24 0:28 ` Eric Dumazet
2010-10-30 11:34 ` [PATCH 0/1] RFC: poll/select performance on datagram sockets Alban Crequy
2010-10-30 12:53 ` Eric Dumazet
2010-10-30 13:17 ` Eric Dumazet
[not found] ` <20101030224703.065e70f6@chocolatine.cbg.collabora.co.uk>
2010-10-31 15:36 ` [PATCH 1/2] af_unix: fix unix_dgram_poll() behavior for EPOLLOUT event Eric Dumazet
2010-10-31 19:07 ` Davide Libenzi
2010-11-08 21:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1010301042040.12598@davide-lnx1 \
--to=davidel@xmailserver.org \
--cc=adobriyan@gmail.com \
--cc=alban.crequy@collabora.co.uk \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pauli.nieminen@collabora.co.uk \
--cc=rweikusat@mssgmbh.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox