From: Julia Lawall <julia.lawall@lip6.fr>
To: Antonio Murdaca <antonio.murdaca@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, joe@perches.com,
julia.lawall@lip6.fr, akpm@linux-foundation.org
Subject: Re: [PATCH] ethernet: micrel: use time_after_eq macro
Date: Fri, 5 Jun 2015 17:45:50 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1506051745370.2388@hadrien> (raw)
In-Reply-To: <1433514627-16845-1-git-send-email-antonio.murdaca@gmail.com>
On Fri, 5 Jun 2015, Antonio Murdaca wrote:
> use time_after_eq macro for time comparison
>
> Signed-off-by: Antonio Murdaca <antonio.murdaca@gmail.com>
> ---
> drivers/net/ethernet/micrel/ksz884x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c
> index 48d2aec..9bce30c 100644
> --- a/drivers/net/ethernet/micrel/ksz884x.c
> +++ b/drivers/net/ethernet/micrel/ksz884x.c
> @@ -6689,7 +6689,7 @@ static void mib_monitor(unsigned long ptr)
>
> /* This is used to verify Wake-on-LAN is working. */
> if (hw_priv->pme_wait) {
> - if (hw_priv->pme_wait <= jiffies) {
> + if (time_after_eq(jiffies, hw_priv->pme_wait)) {
There is also time_is_before_eq_jiffies.
julia
> hw_clr_wol_pme_status(&hw_priv->hw);
> hw_priv->pme_wait = 0;
> }
> --
> 2.4.2
>
>
next prev parent reply other threads:[~2015-06-05 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 14:30 [PATCH] ethernet: micrel: use time_after_eq macro Antonio Murdaca
2015-06-05 15:45 ` Julia Lawall [this message]
2015-06-05 16:54 ` Antonio Murdaca
-- strict thread matches above, loose matches on Subject: below --
2015-06-05 14:37 Antonio Murdaca
2015-06-05 14:42 Antonio Murdaca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1506051745370.2388@hadrien \
--to=julia.lawall@lip6.fr \
--cc=akpm@linux-foundation.org \
--cc=antonio.murdaca@gmail.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox