From: Julia Lawall <julia.lawall@lip6.fr>
To: thloh@altera.com
Cc: robh+dt@kernel.org, mark.rutland@arm.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com, davem@davemloft.net,
preid@electromag.com.au, dinguyen@opensource.altera.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, thloh85@gmail.com,
cnphoon@altera.com, thloh@altera.com, kbuild-all@01.org
Subject: [PATCH] net: ethernet: fix odd_ptr_err.cocci warnings
Date: Tue, 21 Jun 2016 12:03:28 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1606211201310.2882@hadrien> (raw)
PTR_ERR should normally access the value just tested by IS_ERR
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Tien Hock Loh <thloh@altera.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
This patch refers to the following code:
url:
https://github.com/0day-ci/linux/commits/thloh-altera-com/net-ethernet-Add-T
SE-PCS-support-to-dwmac-socfpga/20160621-164854
dwmac-socfpga.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -224,7 +224,7 @@ static int socfpga_dwmac_parse_data(stru
dev_err(dev,
"%s: ERROR: failed mapping tse control port\n",
__func__);
- return PTR_ERR(dwmac->pcs.sgmii_adapter_base);
+ return PTR_ERR(dwmac->pcs.tse_pcs_base);
}
}
}
next reply other threads:[~2016-06-21 10:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 10:03 Julia Lawall [this message]
2016-06-23 19:21 ` [PATCH] net: ethernet: fix odd_ptr_err.cocci warnings David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1606211201310.2882@hadrien \
--to=julia.lawall@lip6.fr \
--cc=alexandre.torgue@st.com \
--cc=cnphoon@altera.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=preid@electromag.com.au \
--cc=robh+dt@kernel.org \
--cc=thloh85@gmail.com \
--cc=thloh@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox