Netdev List
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Hall, Christopher S" <christopher.s.hall@intel.com>
Cc: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"john.stultz@linaro.org" <john.stultz@linaro.org>,
	"richardcochran@gmail.com" <richardcochran@gmail.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"peterz@infradead.org" <peterz@infradead.org>
Subject: RE: [PATCH v3 1/4] Add correlated clocksource deriving system time from an auxiliary clocksource
Date: Fri, 4 Sep 2015 15:02:19 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1509041438520.15006@nanos> (raw)
In-Reply-To: <B79D786B7111A34A8CF09F833429C493A90B2D1F@ORSMSX109.amr.corp.intel.com>

On Thu, 3 Sep 2015, Hall, Christopher S wrote:

Can you please teach your mail client to add proper line breaks around
80? Your mail renders horrible in a text based mail client.

> In addition to the network interface, ART will be used in the audio
> interface as well.  We need to support the case where an audio
> co-processor will control the audio device.  In this case, the
> get_ts() function supplied by the audio driver will be very slow
> (several milliseconds) and the result will be out of date by some
> fraction of that amount.

You are not telling at all, what this driver is supposed to do, what
this get_ts() function is for and how that co-processor thing works.

You just make claims, that you need this without explaining WHY. And
that WHY is the most interesting part.

> This loop makes strict requirements on the latency and recency. Is
> it possible to relax that requirement in some way?

No. This function is explicitely for the precise timestamp usecase,
which is required by PTP and other sane use cases.

> For example, supply the ART value as an argument and, in the case of
> the realtime clock, keep a short history of clock changes.  It would

It's not only clock realtime which is affected by those.

> fail in cases where there are a lot of calls to adjtimex(),

That has nothing to do with lots of adjtimex calls. The kernel does a
slow correction of the conversion values itself to avoid time jumping
around.

> but it will would work most of the time.

Will, would, most? - Could, perhaps, sometimes?

Looks like a design from the trainwreck engineering departement. We
want to have it very precise, but we don't care if it behaves like a
random number generator.

Can you folks please get your act together and provide coherent
explanations about the usecase and the constraints instead of
proposing random functions with obscure semantics?

Thanks,

	tglx

  parent reply	other threads:[~2015-09-04 13:02 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-21 18:52 [PATCH v3 0/4] Patchset enabling hardware based cross-timestamps for next gen Intel platforms Christopher S. Hall
2015-08-21 18:52 ` [PATCH v3 1/4] Add correlated clocksource deriving system time from an auxiliary clocksource Christopher S. Hall
2015-08-22 20:17   ` Thomas Gleixner
2015-09-03 23:20     ` Hall, Christopher S
2015-09-04  8:11       ` Richard Cochran
2015-09-04 14:28         ` Peter Zijlstra
2015-09-04 21:12           ` Hall, Christopher S
2015-09-04 13:02       ` Thomas Gleixner [this message]
2015-09-04 15:10         ` Peter Zijlstra
2015-09-04 15:17           ` Richard Cochran
2015-09-04 15:41             ` Peter Zijlstra
2015-09-04 16:35               ` Thomas Gleixner
2015-09-04 21:01                 ` Hall, Christopher S
2015-09-05  8:46                   ` Thomas Gleixner
2015-09-05 10:04                     ` Ingo Molnar
2015-09-04 15:32         ` Richard Cochran
2015-09-04 21:50       ` John Stultz
2015-08-21 18:52 ` [PATCH v3 2/4] Added ART correlated clocksource and ART CPU feature Christopher S. Hall
2015-08-22 20:26   ` Thomas Gleixner
2015-08-21 18:52 ` [PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl Christopher S. Hall
2015-08-22 20:33   ` Thomas Gleixner
2015-08-22 21:17     ` Richard Cochran
2015-08-23  8:15       ` Thomas Gleixner
2015-08-23 11:25         ` Richard Cochran
2015-08-24 20:16           ` Hall, Christopher S
2015-08-25  7:31             ` Richard Cochran
2015-08-21 18:52 ` [PATCH v3 4/4] Enabling hardware supported PTP system/device crosstimestamping Christopher S. Hall
2015-08-22 20:46   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1509041438520.15006@nanos \
    --to=tglx@linutronix.de \
    --cc=christopher.s.hall@intel.com \
    --cc=hpa@zytor.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=richardcochran@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox