From: Thomas Gleixner <tglx@linutronix.de>
To: "Christopher S. Hall" <christopher.s.hall@intel.com>
Cc: richardcochran@gmail.com, mingo@redhat.com,
john.stultz@linaro.org, hpa@zytor.com,
jeffrey.t.kirsher@intel.com, x86@kernel.org,
linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, kevin.b.stanton@intel.com,
kevin.j.clarke@intel.com
Subject: Re: [PATCH v8 5/8] time: Add history to cross timestamp interface supporting slower devices
Date: Wed, 24 Feb 2016 11:56:49 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1602241155340.3670@nanos> (raw)
In-Reply-To: <1456139726-3327-6-git-send-email-christopher.s.hall@intel.com>
On Mon, 22 Feb 2016, Christopher S. Hall wrote:
> +{
> + struct timekeeper *tk = &tk_core.timekeeper;
> + bool interp_forward;
> + u64 corr_raw, corr_real;
> + int ret;
Once more:
struct timekeeper *tk = &tk_core.timekeeper;
u64 corr_raw, corr_real;
bool interp_forward;
int ret;
Is way simpler to parse fast.
> {
> struct timekeeper *tk = &tk_core.timekeeper;
> @@ -929,6 +1046,12 @@ int get_device_system_crosststamp(int (*get_time_fn)
> ktime_t base_real;
> s64 nsec_raw;
> s64 nsec_real;
> + cycles_t cycles;
> + cycle_t now;
> + cycle_t interval_start;
> + unsigned int clock_was_set_seq;
> + u8 cs_was_changed_seq;
> + bool do_interp;
Single lines for same types .....
Other than that:
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2016-02-24 10:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 11:15 [PATCH v8 0/8] Patchset enabling hardware based cross-timestamps for next gen Intel platforms Christopher S. Hall
2016-02-22 11:15 ` [PATCH v8 1/8] time: Add cycles to nanoseconds translation Christopher S. Hall
2016-02-24 10:49 ` Thomas Gleixner
2016-02-22 11:15 ` [PATCH v8 2/8] time: Add timekeeping snapshot code capturing system time and counter Christopher S. Hall
2016-02-24 10:51 ` Thomas Gleixner
2016-02-22 11:15 ` [PATCH v8 3/8] time: Remove duplicated code in ktime_get_raw_and_real() Christopher S. Hall
2016-02-24 10:52 ` Thomas Gleixner
2016-02-22 11:15 ` [PATCH v8 4/8] time: Add driver cross timestamp interface for higher precision time synchronization Christopher S. Hall
2016-02-24 10:54 ` Thomas Gleixner
2016-02-22 11:15 ` [PATCH v8 5/8] time: Add history to cross timestamp interface supporting slower devices Christopher S. Hall
2016-02-24 10:56 ` Thomas Gleixner [this message]
2016-02-24 23:07 ` John Stultz
2016-02-22 11:15 ` [PATCH v8 6/8] x86: tsc: Always Running Timer (ART) correlated clocksource Christopher S. Hall
2016-02-24 11:00 ` Thomas Gleixner
2016-02-22 11:15 ` [PATCH v8 7/8] ptp: Add PTP_SYS_OFFSET_PRECISE for driver crosstimestamping Christopher S. Hall
2016-02-22 11:15 ` [PATCH v8 8/8] net: e1000e: Adds hardware supported cross timestamp on e1000e nic Christopher S. Hall
2016-02-24 20:22 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1602241155340.3670@nanos \
--to=tglx@linutronix.de \
--cc=christopher.s.hall@intel.com \
--cc=hpa@zytor.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=john.stultz@linaro.org \
--cc=kevin.b.stanton@intel.com \
--cc=kevin.j.clarke@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox