From: Thomas Gleixner <tglx@linutronix.de>
To: Jens Axboe <axboe@fb.com>
Cc: Sagi Grimberg <sagi@grimberg.me>, Jes Sorensen <jsorensen@fb.com>,
Tariq Toukan <tariqt@mellanox.com>,
Saeed Mahameed <saeedm@dev.mellanox.co.il>,
Networking <netdev@vger.kernel.org>,
Leon Romanovsky <leonro@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Kernel Team <kernel-team@fb.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: mlx5 broken affinity
Date: Thu, 9 Nov 2017 22:23:47 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1711092220160.2690@nanos> (raw)
In-Reply-To: <4888ac89-22d5-0700-daa1-d604e4c54970@fb.com>
On Thu, 9 Nov 2017, Jens Axboe wrote:
> On 11/09/2017 10:03 AM, Thomas Gleixner wrote:
> > On Thu, 9 Nov 2017, Jens Axboe wrote:
> >> On 11/09/2017 07:19 AM, Thomas Gleixner wrote:
> >> If that's the attitude at your end, then I do suggest we just revert the
> >> driver changes. Clearly this isn't going to be productive going forward.
> >>
> >> The better solution was to make the managed setup more flexible, but
> >> it doesn't sound like that is going to be viable at all.
> >
> > That's not true. I indicated several times, that we can do that, but not
> > just by breaking the managed facility.
> >
> > What I'm arguing against is that the blame is focused on those who
> > implemented the managed facility with the existing semantics.
> >
> > I'm still waiting for a proper description of what needs to be changed in
> > order to make these drivers work again. All I have seen so far is to break
> > managed interrupts completely and that's not going to happen.
>
> There's no blame as far as I'm concerned, just frustration that we broke
> this and folks apparently not acknowledging that it's a concern.
>
> What used to work was that you could move IRQs around as you wanted to.
> That was very useful for custom setups, for tuning, or for isolation
> purposes. None of that works now, which is unfortunate.
Well, its unfortunate and I can understand your frustration, but I really
have a hard time to understand that these concerns have not been brought up
when the whole thing was discussed and in the early stages of
implementation way before it got merged.
It was not my decision to make it the way it is and I merily try to prevent
hasty and damaging hackery right now.
I'll answer to the technical details in a separate mail.
Thanks,
tglx
next prev parent reply other threads:[~2017-11-09 21:24 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 16:19 mlx5 broken affinity Jes Sorensen
2017-11-01 17:21 ` Sagi Grimberg
2017-11-01 18:20 ` Jes Sorensen
2017-11-01 22:41 ` Saeed Mahameed
2017-11-01 23:02 ` Jes Sorensen
2017-11-02 8:28 ` Tariq Toukan
2017-11-02 10:08 ` Sagi Grimberg
2017-11-02 12:13 ` Andrew Lunn
2017-11-02 14:48 ` Jes Sorensen
2017-11-02 16:14 ` Sagi Grimberg
2017-11-02 17:13 ` Jes Sorensen
2017-11-02 18:10 ` Thomas Gleixner
2017-11-05 8:36 ` Sagi Grimberg
2017-11-07 15:07 ` Thomas Gleixner
2017-11-08 7:27 ` Sagi Grimberg
2017-11-08 12:21 ` David Laight
2017-11-08 16:13 ` Jens Axboe
2017-11-09 10:09 ` Christoph Hellwig
2017-11-09 15:18 ` Jens Axboe
2017-11-09 15:08 ` Saeed Mahameed
2017-11-09 15:40 ` Sagi Grimberg
2017-11-08 16:19 ` Jes Sorensen
2017-11-08 17:33 ` Thomas Gleixner
2017-11-09 10:50 ` Sagi Grimberg
2017-11-09 14:19 ` Thomas Gleixner
2017-11-09 15:21 ` Jens Axboe
2017-11-09 17:03 ` Thomas Gleixner
2017-11-09 20:11 ` Jens Axboe
2017-11-09 21:23 ` Thomas Gleixner [this message]
2017-11-09 21:30 ` Jens Axboe
2017-11-09 21:42 ` [RFD] Managed interrupt affinities [ Was: mlx5 broken affinity ] Thomas Gleixner
2017-11-10 5:56 ` Saeed Mahameed
2017-11-10 13:03 ` Thomas Gleixner
2017-11-13 19:20 ` Sagi Grimberg
2017-11-13 20:51 ` Thomas Gleixner
2017-11-13 21:13 ` Sagi Grimberg
2017-11-13 21:33 ` Thomas Gleixner
2017-11-13 21:49 ` Sagi Grimberg
2017-11-14 10:15 ` Thomas Gleixner
2017-11-09 16:01 ` mlx5 broken affinity Sagi Grimberg
2017-11-09 16:09 ` Jens Axboe
2017-11-09 17:07 ` Thomas Gleixner
2017-11-09 20:12 ` Jens Axboe
2017-11-09 21:25 ` Thomas Gleixner
2017-11-09 15:19 ` Jens Axboe
2017-11-09 22:03 ` Jes Sorensen
2017-11-02 7:57 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1711092220160.2690@nanos \
--to=tglx@linutronix.de \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=jsorensen@fb.com \
--cc=kernel-team@fb.com \
--cc=leonro@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@dev.mellanox.co.il \
--cc=saeedm@mellanox.com \
--cc=sagi@grimberg.me \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox