* [PATCH] netfilter: nf_tables: fix odd_ptr_err.cocci warnings
@ 2018-01-11 14:02 Julia Lawall
2018-01-11 14:07 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2018-01-11 14:02 UTC (permalink / raw)
To: Pablo Neira Ayuso
Cc: Jozsef Kadlecsik, Florian Westphal, netfilter-devel, coreteam,
netdev, linux-kernel, kbuild-all
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: b4464bcab38d3f7fe995a7cb960eeac6889bec08
commit: 3b49e2e94e6ebb8b23d0955d9e898254455734f8 [8286/9035] netfilter:
nf_tables: add flow table netlink frontend
The following is a 0-day report generated by Coccinelle. But from the
line before, it looks like the fix is backwards, and the test shoud be on
flowtable.
julia
nf_tables_api.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -5419,7 +5419,7 @@ static int nf_tables_getflowtable(struct
flowtable = nf_tables_flowtable_lookup(table, nla[NFTA_FLOWTABLE_NAME],
genmask);
if (IS_ERR(table))
- return PTR_ERR(flowtable);
+ return PTR_ERR(table);
skb2 = alloc_skb(NLMSG_GOODSIZE, GFP_KERNEL);
if (!skb2)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] netfilter: nf_tables: fix odd_ptr_err.cocci warnings
2018-01-11 14:02 [PATCH] netfilter: nf_tables: fix odd_ptr_err.cocci warnings Julia Lawall
@ 2018-01-11 14:07 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2018-01-11 14:07 UTC (permalink / raw)
To: Julia Lawall
Cc: Jozsef Kadlecsik, Florian Westphal, netfilter-devel, coreteam,
netdev, linux-kernel, kbuild-all
On Thu, Jan 11, 2018 at 03:02:12PM +0100, Julia Lawall wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: b4464bcab38d3f7fe995a7cb960eeac6889bec08
> commit: 3b49e2e94e6ebb8b23d0955d9e898254455734f8 [8286/9035] netfilter:
> nf_tables: add flow table netlink frontend
>
> The following is a 0-day report generated by Coccinelle. But from the
> line before, it looks like the fix is backwards, and the test shoud be on
> flowtable.
There's a fix for this in nf-next.git
https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git/commit/?id=03a0120f75dfb1807c0441376e26b36160087de4
Will pass it up to David asap.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-11 14:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-11 14:02 [PATCH] netfilter: nf_tables: fix odd_ptr_err.cocci warnings Julia Lawall
2018-01-11 14:07 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox