From: Thomas Gleixner <tglx@linutronix.de>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
arjan@linux.intel.com, airlied@gmail.com, davem@davemloft.net,
Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH 2.6.27-rc8 5/6] e1000e: debug contention on NVM SWFLAG
Date: Fri, 3 Oct 2008 21:38:44 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.0810032137390.4573@apollo> (raw)
In-Reply-To: <alpine.LNX.1.10.0810031736150.26779@jikos.suse.cz>
On Fri, 3 Oct 2008, Jiri Kosina wrote:
> On Fri, 3 Oct 2008, Linus Torvalds wrote:
>
> > > The debugging message is racy anyway with respect to accessing
> > > nvm_owner, right? It should be done after the mutex has been
> > > succesfully acquired.
> > It's done that way on purpose - to see who _could_ be racing.
>
> I know. I just wanted to point out that we probably don't want the patch
> in 2.6.27 in this form, users wouldn't like to have warning in their logs
> every time mutex is not acquired on a first attempt :)
Yeah, it should go before .27 final. It now just gathers data as
people actually care about warn_ons or they are even caught
automatically via kernel oops.
Thanks,
tglx
next prev parent reply other threads:[~2008-10-03 19:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 23:33 [PATCH 2.6.27-rc8 0/6] e1000e mutex protection Jesse Brandeburg
2008-10-02 23:33 ` [PATCH 2.6.27-rc8 1/6] e1000e: reset swflag after resetting hardware Jesse Brandeburg
2008-10-02 23:33 ` [PATCH 2.6.27-rc8 2/6] e1000e: do not ever sleep in interrupt context Jesse Brandeburg
2008-10-03 0:36 ` Thomas Gleixner
2008-10-02 23:33 ` [PATCH 2.6.27-rc8 3/6] e1000e: remove phy read from inside spinlock Jesse Brandeburg
2008-10-03 0:37 ` Thomas Gleixner
2008-10-02 23:33 ` [PATCH 2.6.27-rc8 4/6] e1000e: drop stats lock Jesse Brandeburg
2008-10-03 0:38 ` Thomas Gleixner
2008-10-02 23:33 ` [PATCH 2.6.27-rc8 5/6] e1000e: debug contention on NVM SWFLAG Jesse Brandeburg
2008-10-03 11:47 ` Jiri Kosina
2008-10-03 15:16 ` Linus Torvalds
2008-10-03 15:39 ` Jiri Kosina
2008-10-03 19:38 ` Thomas Gleixner [this message]
2008-10-02 23:33 ` [PATCH 2.6.27-rc8 6/6] e1000e: update version from k4 to k6 Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0810032137390.4573@apollo \
--to=tglx@linutronix.de \
--cc=airlied@gmail.com \
--cc=arjan@linux.intel.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=jesse.brandeburg@intel.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox