From: Thomas Gleixner <tglx@linutronix.de>
To: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Cc: davem@davemloft.net, arjan@linux.jf.intel.com,
bhutchings@solarflare.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next v4 2/2] ixgbe: Example usage of the new IRQ affinity_hint callback
Date: Fri, 30 Apr 2010 23:47:59 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1004302346030.2951@localhost.localdomain> (raw)
In-Reply-To: <20100430214517.3992.92545.stgit@ppwaskie-hc2.jf.intel.com>
On Fri, 30 Apr 2010, Peter P Waskiewicz Jr wrote:
> + for (i = 0; i < num_q_vectors; i++) {
> + struct ixgbe_q_vector *q_vector = adapter->q_vector[i];
> + /* release the CPU mask memory */
> + free_cpumask_var(q_vector->affinity_mask);
> + /* clear the affinity_mask in the IRQ descriptor */
> + irq_set_affinity_hint(adapter->msix_entries[i].vector, NULL);
Freeing the mask _AFTER_ clearing the hint might be a worthwhile
exercise :)
Thanks,
tglx
next prev parent reply other threads:[~2010-04-30 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 21:44 [PATCH linux-next v4 1/2] irq: Add CPU mask affinity hint Peter P Waskiewicz Jr
2010-04-30 21:45 ` [PATCH linux-next v4 2/2] ixgbe: Example usage of the new IRQ affinity_hint callback Peter P Waskiewicz Jr
2010-04-30 21:47 ` Thomas Gleixner [this message]
2010-04-30 21:51 ` Peter P Waskiewicz Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1004302346030.2951@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=arjan@linux.jf.intel.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox