* [PATCH] igc: Remove unreachable break after return
@ 2026-07-23 7:04 Hungyu Lin
2026-07-23 13:02 ` Joe Damato
0 siblings, 1 reply; 2+ messages in thread
From: Hungyu Lin @ 2026-07-23 7:04 UTC (permalink / raw)
To: Tony Nguyen, Przemek Kitszel
Cc: Andrew Lunn, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, intel-wired-lan, netdev, linux-kernel, Hungyu Lin
The break statement immediately following the return statement is
unreachable and can never be executed.
Remove the redundant break statement.
No functional change intended.
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
drivers/net/ethernet/intel/igc/igc_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 2c9e2dfd8499..6252d4b68f88 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -2528,7 +2528,6 @@ static int __igc_xdp_run_prog(struct igc_adapter *adapter,
if (xdp_do_redirect(adapter->netdev, xdp, prog) < 0)
goto out_failure;
return IGC_XDP_REDIRECT;
- break;
default:
bpf_warn_invalid_xdp_action(adapter->netdev, prog, act);
fallthrough;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] igc: Remove unreachable break after return
2026-07-23 7:04 [PATCH] igc: Remove unreachable break after return Hungyu Lin
@ 2026-07-23 13:02 ` Joe Damato
0 siblings, 0 replies; 2+ messages in thread
From: Joe Damato @ 2026-07-23 13:02 UTC (permalink / raw)
To: Hungyu Lin
Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, intel-wired-lan,
netdev, linux-kernel
On Thu, Jul 23, 2026 at 07:04:51AM +0000, Hungyu Lin wrote:
> The break statement immediately following the return statement is
> unreachable and can never be executed.
>
> Remove the redundant break statement.
>
> No functional change intended.
>
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index 2c9e2dfd8499..6252d4b68f88 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -2528,7 +2528,6 @@ static int __igc_xdp_run_prog(struct igc_adapter *adapter,
> if (xdp_do_redirect(adapter->netdev, xdp, prog) < 0)
> goto out_failure;
> return IGC_XDP_REDIRECT;
> - break;
Hm, from Documentation/process/maintainer-netdev.rst:
Netdev discourages patches which perform simple clean-ups, which are not in
the context of other work.
I think this patch probably meets the definition of patches which are
discouraged.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-23 13:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-23 7:04 [PATCH] igc: Remove unreachable break after return Hungyu Lin
2026-07-23 13:02 ` Joe Damato
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox