From: Larysa Zaremba <larysa.zaremba@intel.com>
To: Simon Horman <horms@kernel.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>,
<przemyslaw.kitszel@intel.com>, <aleksander.lobakin@intel.com>,
<sridhar.samudrala@intel.com>,
<michal.swiatkowski@linux.intel.com>,
<maciej.fijalkowski@intel.com>, <emil.s.tantilov@intel.com>,
<madhu.chittim@intel.com>, <joshua.a.hay@intel.com>,
<jacob.e.keller@intel.com>, <jayaprakash.shanmugam@intel.com>,
<jiri@resnulli.us>, <corbet@lwn.net>, <richardcochran@gmail.com>,
<skhan@linuxfoundation.org>, <linux-doc@vger.kernel.org>
Subject: Re: [PATCH net-next v5 00/15][pull request] Introduce iXD driver
Date: Mon, 27 Jul 2026 17:10:38 +0200 [thread overview]
Message-ID: <amd07io_6Ba3k9Tc@soc-5CG4396X81.clients.intel.com> (raw)
In-Reply-To: <20260727144713.GO418547@horms.kernel.org>
On Mon, Jul 27, 2026 at 03:47:13PM +0100, Simon Horman wrote:
> On Mon, Jul 27, 2026 at 10:33:25AM +0200, Larysa Zaremba wrote:
> > On Thu, Jul 23, 2026 at 06:15:26AM -0700, Jakub Kicinski wrote:
> > > On Mon, 20 Jul 2026 18:24:15 +0200 Larysa Zaremba wrote:
> > > > I have looked though Sashiko feedback for this version. A lot medium+ comments
> > > > were things that I have addressed as false-positives in v4, so those are left
> > > > out, same as many of low-severity subjective issues. Unfortunately, patch 4 does
> > > > need a fixup (see Re: for the patch itself), but hopefully this does not warrant
> > > > another PR.
> > >
> > > There's gazillion patches in the queue. Just fix the bugs and repost.
> > > This "we will follow up" attitude is getting out of hand IMHO.
> >
> > I was suggesting you could apply the fixup that I have posted under patch 4
> > ("libie: add control queue support"). If this is not possible, then Tony will do
> > that and send another revision. (please respond)
> >
> > Other feedback does not interfere with code working as intended, although
> > Sashiko's feedback was pretty valuable in getting to the point where I can say
> > that.
> >
> > I see that Simon posted only medium+ feedback, I could address it one-by-one
> > once more, if anyone would read that.
>
> I realise that in the case of this patchset I forwarded AI-generated review
> which somewhat overlapped with your own efforts: somehow I missed your
> emails and I apologise for that.
>
> But I wanted to make a general statement regarding commenting on
> AI-generated review:
>
> I do try (and as we see, sometimes fail), to take into account prior
> discussion on the mailing list as part of my review process. And I would
> like to think that I am not alone in taking this approach. So to that
> extent, I think that responses on the ML to concerns flagged by
> AI-generated review have value.
I appretiate the insight, but this suggestion wasn't in any way targeted at you.
I know that you usually filter the feedback.
It is more about whether addressing ALL medium+ feedback in an organized manner
for this particular version would reassure anyone that the code is correct.
prev parent reply other threads:[~2026-07-27 15:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 18:00 [PATCH net-next v5 00/15][pull request] Introduce iXD driver Tony Nguyen
2026-07-15 18:00 ` [PATCH net-next v5 01/15] virtchnl: move virtchnl and virtchnl2 headers to 'include/linux/net/intel' Tony Nguyen
2026-07-15 18:00 ` [PATCH net-next v5 02/15] libie: add PCI device initialization helpers to libie Tony Nguyen
2026-07-15 18:00 ` [PATCH net-next v5 03/15] libeth: allow to create fill queues without NAPI Tony Nguyen
2026-07-15 18:00 ` [PATCH net-next v5 04/15] libie: add control queue support Tony Nguyen
2026-07-20 16:17 ` Larysa Zaremba
2026-07-22 15:54 ` Simon Horman
2026-07-15 18:00 ` [PATCH net-next v5 05/15] libie: add bookkeeping support for control queue messages Tony Nguyen
2026-07-20 16:07 ` Larysa Zaremba
2026-07-22 15:55 ` Simon Horman
2026-07-15 18:00 ` [PATCH net-next v5 06/15] idpf: remove 'vport_params_reqd' field Tony Nguyen
2026-07-15 18:00 ` [PATCH net-next v5 07/15] idpf: remove unused code for getting RSS info from device Tony Nguyen
2026-07-15 18:00 ` [PATCH net-next v5 08/15] idpf: refactor idpf to use libie_pci APIs Tony Nguyen
2026-07-20 16:09 ` Larysa Zaremba
2026-07-22 16:13 ` Simon Horman
2026-07-15 18:00 ` [PATCH net-next v5 09/15] idpf: refactor idpf to use libie control queues Tony Nguyen
2026-07-20 16:11 ` Larysa Zaremba
2026-07-22 16:16 ` Simon Horman
2026-07-15 18:00 ` [PATCH net-next v5 10/15] idpf: make mbx_task queueing and cancelling more consistent Tony Nguyen
2026-07-15 18:00 ` [PATCH net-next v5 11/15] idpf: print a debug message and bail in case of non-event ctlq message Tony Nguyen
2026-07-15 18:00 ` [PATCH net-next v5 12/15] ixd: add basic driver framework for Intel(R) Control Plane Function Tony Nguyen
2026-07-15 18:00 ` [PATCH net-next v5 13/15] ixd: add reset checks and initialize the mailbox Tony Nguyen
2026-07-22 16:17 ` Simon Horman
2026-07-15 18:00 ` [PATCH net-next v5 14/15] ixd: add the core initialization Tony Nguyen
2026-07-20 16:14 ` Larysa Zaremba
2026-07-22 16:18 ` Simon Horman
2026-07-23 10:28 ` Maciej Fijalkowski
2026-07-23 12:51 ` Simon Horman
2026-07-15 18:00 ` [PATCH net-next v5 15/15] ixd: add devlink support Tony Nguyen
2026-07-20 16:24 ` [PATCH net-next v5 00/15][pull request] Introduce iXD driver Larysa Zaremba
2026-07-23 13:15 ` Jakub Kicinski
2026-07-27 8:33 ` Larysa Zaremba
2026-07-27 14:47 ` Simon Horman
2026-07-27 15:10 ` Larysa Zaremba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amd07io_6Ba3k9Tc@soc-5CG4396X81.clients.intel.com \
--to=larysa.zaremba@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=emil.s.tantilov@intel.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jayaprakash.shanmugam@intel.com \
--cc=jiri@resnulli.us \
--cc=joshua.a.hay@intel.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=madhu.chittim@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox