Re: [PATCH net-next] vsock: remove dev_hold() and dev_put() in __vsock_deliver_tap_skb()

[Bobby Eshleman <bobbyeshleman@gmail.com>]

On Mon, Sep 21, 2026 at 09:42:18AM +0000, Eric Dumazet wrote:
> __vsock_deliver_tap_skb() is called from vsock_deliver_tap()
> under rcu_read_lock().
> 
> dev_queue_xmit() does not require the caller to hold a device reference
> count, and the device lifetime is already protected by RCU.
> 
> Remove the redundant dev_hold(dev) and dev_put(dev) calls.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Stefano Garzarella <sgarzare@redhat.com>
> ---
>  net/vmw_vsock/af_vsock_tap.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/net/vmw_vsock/af_vsock_tap.c b/net/vmw_vsock/af_vsock_tap.c
> index 30ee7e4fe25115cef71b43f335862a09b8c51382..7c5cdceabb2a5f7079faab243ee9de7d6bb8857c 100644
> --- a/net/vmw_vsock/af_vsock_tap.c
> +++ b/net/vmw_vsock/af_vsock_tap.c
> @@ -64,14 +64,10 @@ static int __vsock_deliver_tap_skb(struct sk_buff *skb,
>  	struct sk_buff *nskb = skb_clone(skb, GFP_ATOMIC);
>  
>  	if (nskb) {
> -		dev_hold(dev);
> -
>  		nskb->dev = dev;
>  		ret = dev_queue_xmit(nskb);
>  		if (unlikely(ret > 0))
>  			ret = net_xmit_errno(ret);
> -
> -		dev_put(dev);
>  	}
>  
>  	return ret;
> -- 
> 2.55.0.1082.g2b9226bbc0-goog
> 

Reviewed-by: Bobby Eshleman <bobbyeshleman@meta.com>