From: Stefano Garzarella <sgarzare@redhat.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] vsock: remove dev_hold() and dev_put() in __vsock_deliver_tap_skb()
Date: Tue, 22 Sep 2026 12:45:01 +0200 [thread overview]
Message-ID: <arJcFUflXLlF6wzA@sgarzare-redhat> (raw)
In-Reply-To: <20260921094218.483234-1-edumazet@google.com>
On Mon, Sep 21, 2026 at 09:42:18AM +0000, Eric Dumazet wrote:
>__vsock_deliver_tap_skb() is called from vsock_deliver_tap()
>under rcu_read_lock().
>
>dev_queue_xmit() does not require the caller to hold a device reference
>count, and the device lifetime is already protected by RCU.
>
>Remove the redundant dev_hold(dev) and dev_put(dev) calls.
>
>Signed-off-by: Eric Dumazet <edumazet@google.com>
>Cc: Stefano Garzarella <sgarzare@redhat.com>
>---
> net/vmw_vsock/af_vsock_tap.c | 4 ----
> 1 file changed, 4 deletions(-)
LGTM!
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
next prev parent reply other threads:[~2026-09-22 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 9:42 [PATCH net-next] vsock: remove dev_hold() and dev_put() in __vsock_deliver_tap_skb() Eric Dumazet
2026-09-21 17:32 ` Bobby Eshleman
2026-09-22 10:45 ` Stefano Garzarella [this message]
2026-09-22 13:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arJcFUflXLlF6wzA@sgarzare-redhat \
--to=sgarzare@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox