From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Fernando Fernandez Mancera <fmancera@suse.de>
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,
edumazet@kernel.org, horms@kernel.org, fw@strlen.de, ja@ssi.bg,
lorenzo@kernel.org
Subject: Re: [PATCH net-next 00/15] Netfilter/IPVS updates for net-next
Date: Thu, 15 Oct 2026 12:18:40 +0200 [thread overview]
Message-ID: <atCogI3gNxxPjKxo@chamomile> (raw)
In-Reply-To: <21b46e85-49db-4c7f-9fd7-f32528f2dc4d@suse.de>
On Thu, Oct 15, 2026 at 11:48:39AM +0200, Fernando Fernandez Mancera wrote:
> On 10/14/26 1:11 AM, Pablo Neira Ayuso wrote:
> > Hi,
> >
> > +Cc: lorenzo@kernel.org
> >
> > This is a report on sashiko's findings:
> >
> > https://sashiko.dev/#/patchset/20261011215953.1334630-1-pablo%40netfilter.org
> >
> > On Sun, Oct 11, 2026 at 11:59:38PM +0200, Pablo Neira Ayuso wrote:
> > > Hi,
> > >
> > > The following patchset contains Netfilter/IPVS updates for net-next:
> > >
> > > 1) Disable br_netfilter in userns and schedule it for removal in 2027,
> > > from Florian Westphal.
> > >
> > > 2) Prepare the flowtable to support for IPv4 over IPv6 tunneling and
> > > vice-versa, this includes 5 patches from Lorenzo Bianconi.
> >
> > I am afraid this preparation series is enabling more than it should,
> > sashiko reports type confusion is possible, for example:
> >
> > 1/5 netfilter: flowtable: recognize IPv4/IPv6 in tunnel proto matching
> >
> > this adds the initial pre-processing of IPv6-over-IPv4.
> >
> > But then, nf_flow_offload_lookup() expects to handle IPv4, not an IPv6
> > packet.
> >
> > I will repost this PR keeping them back.
> >
> > > 3) Update selftest nft_queue.sh to make it more stable on debug
> > > kernels, from Jakub Kicinski.
> > >
> > > 4) Fix a overflow in IPVS sync messages which can only happen in very
> > > old 2.6 kernels, from Julian Anastasov.
> > >
> > > 5) Flush conntrack gc worker when existing netns to address a unlikely
> > > UaF, from Florian Westphal.
> > >
> > > 6) Switch nf_tables chain types to use rcu, otherwise module removal
> > > can trigger UaF, also from Florian.
> > >
> > > 7) Add two new helper functions to validate that socket is of inet type,
> > > coming in 2 patches from Florian Westphal.
> >
> > sashiko reports:
> >
> > "If an IPv4 packet from an AF_INET socket is encapsulated by an IPv6 tunnel,
> > the tunnel preserves the AF_INET socket in skb->sk while transmitting the
> > outer IPv6 packet on the LOCAL_OUT path."
> >
> > This sounds like an unrelated issue, I don't know yet how that can
> > happen TBH.
> >
> > > 8) Remove redundant parsing in nft_exthdr for the tcp options case,
> > > from Fernando F. Mancera.
> > >
> > > 9) Remove redundant skb_header_pointer() calls in nft_exthdr for tcp
> > > options, from Fernando F. Mancera.
> >
> > Sashiko here reports this now drops malformed packets instead of
> > NFT_BREAK, which is fine, maybe just extend it to tell about this in
> > the patch description.
>
> Hi Pablo,
>
> Should I re-post a v2 of this patch or will you ammend the commit message to
> add this bit?
I will amend the commit message here, no problem.
next prev parent reply other threads:[~2026-10-15 10:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 21:59 [PATCH net-next 00/15] Netfilter/IPVS updates for net-next Pablo Neira Ayuso
2026-10-11 21:59 ` [PATCH net-next 01/15] netfilter: disable br_netfilter in user namespaces Pablo Neira Ayuso
2026-10-11 21:59 ` [PATCH net-next 02/15] netfilter: flowtable: recognize IPv4/IPv6 in tunnel proto matching Pablo Neira Ayuso
2026-10-11 21:59 ` [PATCH net-next 03/15] netfilter: flowtable: set inner protocol when popping tunnel header Pablo Neira Ayuso
2026-10-11 21:59 ` [PATCH net-next 04/15] netfilter: flowtable: populate tunnel tuple regardless of inner protocol Pablo Neira Ayuso
2026-10-11 21:59 ` [PATCH net-next 05/15] netfilter: flowtable: add encap_proto to flow_offload_tunnel Pablo Neira Ayuso
2026-10-11 21:59 ` [PATCH net-next 06/15] netfilter: flowtable: refactor MTU check for tunnel offload Pablo Neira Ayuso
2026-10-11 21:59 ` [PATCH net-next 07/15] netfilter: flowtable: unify tunnel push for IPv4 and IPv6 Pablo Neira Ayuso
2026-10-11 21:59 ` [PATCH net-next 08/15] selftests: netfilter: nft_queue.sh: only queue icmp echo request/reply Pablo Neira Ayuso
2026-10-11 21:59 ` [PATCH net-next 09/15] ipvs: fix buffer overflow when sending sync messages Pablo Neira Ayuso
2026-10-11 21:59 ` [PATCH net-next 10/15] netfilter: conntrack: fix unlikely UaF in gc worker Pablo Neira Ayuso
2026-10-11 21:59 ` [PATCH net-next 11/15] netfilter: nf_tables: switch chain_types array to rcu Pablo Neira Ayuso
2026-10-11 21:59 ` [PATCH net-next 12/15] netfilter: add nf_skb_sk helper and use it Pablo Neira Ayuso
2026-10-11 21:59 ` [PATCH net-next 13/15] netfilter: add nf_sk_to_full_sk " Pablo Neira Ayuso
2026-10-11 21:59 ` [PATCH net-next 14/15] netfilter: nft_exthdr: remove redundant op parsing in tcp_set_init Pablo Neira Ayuso
2026-10-11 21:59 ` [PATCH net-next 15/15] netfilter: nft_exthdr: avoid 60 bytes stack buffer in TCP option mangling Pablo Neira Ayuso
2026-10-13 23:11 ` [PATCH net-next 00/15] Netfilter/IPVS updates for net-next Pablo Neira Ayuso
2026-10-14 10:44 ` Florian Westphal
2026-10-14 11:23 ` Florian Westphal
2026-10-14 11:31 ` Pablo Neira Ayuso
2026-10-15 9:48 ` Fernando Fernandez Mancera
2026-10-15 10:18 ` Pablo Neira Ayuso [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-06-07 9:49 Pablo Neira Ayuso
2026-06-08 11:58 ` Pablo Neira Ayuso
2026-06-08 22:39 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atCogI3gNxxPjKxo@chamomile \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=fmancera@suse.de \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=ja@ssi.bg \
--cc=kuba@kernel.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox