Netdev List
 help / color / mirror / Atom feed
From: Joe Damato <joe@dama.to>
To: Jakub Kicinski <kuba@kernel.org>
Cc: tariqt@nvidia.com, netdev@vger.kernel.org, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	horms@kernel.org, linux-kernel@vger.kernel.org,
	daniel.machon@microchip.com
Subject: Re: [PATCH net-next v2 0/5] net/mlx4: TX helpers and deferred doorbell fix
Date: Thu, 19 Nov 2026 16:31:18 -0800	[thread overview]
Message-ID: <av+U1gCrKGy+SuGU@devvm20253.cco0.facebook.com> (raw)
In-Reply-To: <20261119160559.45b9fc7f@kernel.org>

On Thu, Nov 19, 2026 at 04:05:59PM -0800, Jakub Kicinski wrote:
> On Thu, 19 Nov 2026 15:34:21 -0800 Joe Damato wrote:
> > On Thu, Nov 19, 2026 at 02:38:52PM -0800, Jakub Kicinski wrote:
> > > On Tue, 17 Nov 2026 08:43:25 -0800 Joe Damato wrote:  
> > > > The only fix in this series is the deferred doorbell flush (patch 5), but I
> > > > need the other code (patches 1-4) for SW USO support I plan to submit next
> > > > if this series is applied.  
> > > 
> > > Not sure if this is what you meant but this may read as if you were
> > > sending a fix for net-next for convenience of sending more patches.
> > > To be clear - that's not a valid excuse. That said, here, we're talking
> > > about a 10 year old error path bug which nobody apparently have been
> > > bothered by. We don't have space in net for such things at this point
> > > of the cycle, anyway :S  
> > 
> > I'm probably just being dense and not following what you mean here.
> > 
> > I was looking at a local branch that implements SW USO in mlx4 and it was
> > getting to be quite long with a lot of patches. I thought that breaking it up
> > and moving some of the patches into a standalone series would make it easier
> > to review.
> > 
> > I suppose you are saying I should have just kept it as one longer series,
> > instead?
> 
> No, not at all. 
> 
> You said "The only fix in this series is....I plan to submit next if
> this series is applied". Which triggers my suspicion that you packed
> a fix with -next stuff for expedience / not having to wait for a
> net->net-next merge before you send the rest of USO. I don't think
> that's what you meant but since I had to ping Tariq anyway I decided
> to wag a finger at you. 

Oh, OK.

To be clear: I was not trying to circumvent the system or the rules and if you
(or Tariq) prefers, I am happy to peel this apart and send it to net in the
next cycle.

I am not trying to rush anything in; I'm happy to wait until the next
cycle if that is what is preferred.

I included it to net-next because my perception (which is clearly incorrect)
is that net is much stricter lately and issues which have never been triggered
IRL or reported by users may not meet the bar required for net.

I'll be more careful in the future; I just legitimately did not think this
change would be accepted to net.

> IOW I'm commenting purely on packing what can be perceived as a net
> fix in a net-next series.

Sorry for the confusion I caused :(

      reply	other threads:[~2026-11-20  0:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 15:53 [PATCH net-next v2 0/5] net/mlx4: TX helpers and deferred doorbell fix Joe Damato
2026-11-17 15:53 ` [PATCH net-next v2 1/5] net/mlx4: factor VLAN parsing into mlx4_en_prep_vlan() Joe Damato
2026-11-17 15:53 ` [PATCH net-next v2 2/5] net/mlx4: factor csum flags into mlx4_en_csum_flags() Joe Damato
2026-11-17 15:53 ` [PATCH net-next v2 3/5] net/mlx4: factor HW loopback DMAC into mlx4_en_set_loopback_dmac() Joe Damato
2026-11-17 15:53 ` [PATCH net-next v2 4/5] net/mlx4: track whether a TX doorbell is pending Joe Damato
2026-11-17 15:53 ` [PATCH net-next v2 5/5] net/mlx4: flush pending doorbell when dropping a TX skb Joe Damato
2026-11-17 15:57 ` [PATCH net-next v2 0/5] net/mlx4: TX helpers and deferred doorbell fix netdev-bot+sinfo
2026-11-17 16:43   ` Joe Damato
2026-11-19 22:38     ` Jakub Kicinski
2026-11-19 23:34       ` Joe Damato
2026-11-20  0:05         ` Jakub Kicinski
2026-11-20  0:31           ` Joe Damato [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av+U1gCrKGy+SuGU@devvm20253.cco0.facebook.com \
    --to=joe@dama.to \
    --cc=andrew+netdev@lunn.ch \
    --cc=daniel.machon@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox