From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Magnus Karlsson <magnus.karlsson@gmail.com>
Cc: Petr Oros <poros@redhat.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
<netdev@vger.kernel.org>, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, <edumazet@kernel.org>,
<davem@davemloft.net>, <andrew+netdev@lunn.ch>,
<horms@kernel.org>, Jacob Keller <jacob.e.keller@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Marcin Szycik <marcin.szycik@linux.intel.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2026-11-13 (ice)
Date: Wed, 18 Nov 2026 14:48:58 +0100 [thread overview]
Message-ID: <av2syi6lE/Vp86QW@boxer> (raw)
In-Reply-To: <CAJ8uoz0MMUx68rMZWoZs-JwjodpRixwQSrgpyta1NsanGPn=dg@mail.gmail.com>
On Wed, Nov 18, 2026 at 02:37:06PM +0100, Magnus Karlsson wrote:
> On Wed, 18 Nov 2026 at 13:00, Petr Oros <poros@redhat.com> wrote:
> >
> > I think this pull is a good moment to ask how fixes for Intel drivers
> > should flow, because it is not the first time a fix spent months on
> > intel-wired-lan and then hit a wall on net.
> >
> > My patches 2/6 and 3/6 have been on intel-wired-lan since June, v4 on
> > July 8 [1]. They were reviewed and tested by Intel validation there,
> > and four months later Sashiko found real problems in them on this
> > pull. I have a v5 and will send it once it is tested.
> >
> > Jake's E82x timestamp fixes went through three pulls before a part of
> > them was applied [2], and Maciej described the same loop on the i40e
> > pull in September [3].
> >
> > I know Intel patches go through iwl and are not applied to net
> > directly [4]. But for fixes it means that the review which decides
> > happens on netdev months after the iwl review and validation, and every
> > respin goes through both again. And if iwl stops cross-posting to
> > netdev, as Jakub suggested [5], Sashiko will see Intel fixes only in
> > the pull.
> >
> > So does the iwl round still make sense for fixes? Would it be better to
> > send fixes straight to net with iwl in Cc, and have Tony's ack and the
> > Tested-by from Intel validation on netdev?
>
> Glad you brought this up. IMO, it makes no sense for fixes to go
> through iwl and it makes contributing fixes (or new
> features/optimizations) a lot more painful. Sometimes even to the
> point that you just stop contributing something. I am not in the NIC
> team at Intel, but sometimes I have to do network core work that also
> touches our drivers. In this case, that patch set goes straight to
> net-next (as iwl cannot and should not take core patches), but any
> driver fix that I find on the way needs to go to iwl-net so that it
> can go to net and be backported. So the fixes that my patch set are
> dependent on and that should go in first are instead sent to a
> slow-path (i.e. iwl-net) and after X weeks/months appear in net and
> then net-next. But my patch set in net-next is dependent on these
> fixes so I have to either wait or just cross my fingers that my new
> feature is stable enough even without those fixes. Not optimal in my
> opinion.
>
> So anything that could be done to speed up this process would be very
> welcome. Sending fixes straight to net would be great. The validation
> team could pick those patches up from the list and run the regression
> tests against them, or would that take too long?
Regarding providing Tested-by tags, could we lift the policy where only
Intel validation is allowed to bless the patch? Nowadays with AI regular
dev can spin up a nice pile of tests by themselves.
So if you send a fix and you can find a peer that will test and review it
for you, I don't think we have to wait for validation folks taking care of
it if they are swamped.
I also don't think it would backfire on us and we would introduce some
bloody regressions, given we have {s,cl}ashikos in the pipeline.
>
> Anyway, good initiative. I am sure there is a solution to this that we
> will all like.
>
> /Magnus
>
> > [1] https://lore.kernel.org/all/20260708125755.706263-1-poros@redhat.com/
> > [2] https://lore.kernel.org/all/20261021-jk-e825c-timestamp-processing-logic-fixes-srcu-v5-0-72289a4ac8eb@intel.com/
> > [3] https://lore.kernel.org/all/are4rBUJO3mzrkO8@boxer/
> > [4] https://lore.kernel.org/all/20260721174642.7749143e@kernel.org/
> > [5] https://lore.kernel.org/all/20260922112216.41e6f8cf@kernel.org/
> >
> > Regards,
> > Petr
> >
> >
next prev parent reply other threads:[~2026-11-18 13:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 23:12 [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2026-11-13 (ice) Tony Nguyen
2026-11-13 23:12 ` [PATCH net 1/6] ice: use global queue index in TC to-queue offload Tony Nguyen
2026-11-17 23:54 ` netdev-bot+sashiko
2026-11-13 23:12 ` [PATCH net 2/6] ice: skip per-VLAN promisc rules when default VSI Rx rule is set Tony Nguyen
2026-11-17 23:54 ` netdev-bot+sashiko
2026-11-13 23:12 ` [PATCH net 3/6] ice: preserve uplink DFLT Rx rule on switchdev release Tony Nguyen
2026-11-17 23:54 ` netdev-bot+sashiko
2026-11-13 23:12 ` [PATCH net 4/6] ice: Fix incorrect LLDP filter assumptions Tony Nguyen
2026-11-17 23:54 ` netdev-bot+sashiko
2026-11-13 23:12 ` [PATCH net 5/6] ice: propagate ETH56G deskew poll failures Tony Nguyen
2026-11-17 23:54 ` netdev-bot+sashiko
2026-11-13 23:12 ` [PATCH net 6/6] ice: allow reading the last byte of the NVM and Shadow RAM regions Tony Nguyen
2026-11-13 23:18 ` [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2026-11-13 (ice) netdev-bot+sinfo
2026-11-18 11:59 ` Petr Oros
2026-11-18 13:37 ` Magnus Karlsson
2026-11-18 13:48 ` Maciej Fijalkowski [this message]
2026-11-18 13:51 ` Petr Oros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av2syi6lE/Vp86QW@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=magnus.karlsson@gmail.com \
--cc=marcin.szycik@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox