Re: [PATCH net-next 0/4] selftests: move the AF_XDP test suite from bpf to net

[Maciej Fijalkowski <maciej.fijalkowski@intel.com>]

On Mon, Nov 09, 2026 at 08:52:20AM -0800, Stanislav Fomichev wrote:
> On 11/09, Maciej Fijalkowski wrote:
> > On Thu, Nov 05, 2026 at 12:43:36PM -0800, Stanislav Fomichev wrote:
> > > On 11/05, Maciej Fijalkowski wrote:
> > > > Hi,
> > > > 
> > > > As the maintainers asked, this series is the first step of moving the
> > > > AF_XDP selftests from selftests/bpf to selftests/net: the code moves and
> > > > builds from its new location, without changing what the tests do. The
> > > > rework [0] posted as "selftests: net: migrate AF_XDP test suite over to
> > > > net" (v4) will follow on top of this move.
> > > > 
> > > > Patch 1 drops the test_progs wrapper of the AF_XDP tests, patch 2 adds a
> > > > generic BPF skeleton rule to net/bpf.mk, patch 3 moves xskxceiver, its
> > > > library and test_xsk.sh to selftests/net, and patch 4 (new, not covered
> > > > at [0]) moves xdp_hw_metadata, which is built from the same library.
> > > > 
> > > > The xdp_metadata test stays in test_progs: it covers BPF core
> > > > behaviour, and moving it would mean rewriting it for the kselftest
> > > > harness. It keeps using xsk.c from net/lib/xsk.
> > > > 
> > > > xskxceiver and xdp_hw_metadata are the first users of bpftool at build
> > > > time in selftests/net. NIPA has bpftool, but 0-day and KernelCI build
> > > > net without it, so both tools are skipped with a warning when bpftool
> > > > is missing or does not run.
> > > > 
> > > > test_xsk.sh is installed but not run by run_tests, so NIPA does not pick
> > > > it up: it runs every case, including flaky ones, and some cases leak
> > > > page_pool pages after skb_pp_cow_data() in generic XDP mode on
> > > > veth-based runs. Until a later step makes the suite fit for NIPA, no CI
> > > > runs the AF_XDP tests. test_xsk.sh is being removed by [0] but it is
> > > > kept here as there is no other feasible way to run the test suite (if
> > > > needed) until we come up with an upstreamable Python runner.
> > > > 
> > > > Thanks,
> > > > Maciej
> > > > 
> > > > [0]: https://lore.kernel.org/bpf/20261016174338.787135-1-maciej.fijalkowski@intel.com/
> > > > 
> > > > Maciej Fijalkowski (4):
> > > >   selftests/bpf: drop the test_progs AF_XDP wrapper
> > > >   selftests: net: add a generic rule for BPF skeletons
> > > >   selftests: xsk: move the AF_XDP test suite to selftests/net
> > > >   selftests: net: move xdp_hw_metadata from selftests/bpf
> > > 
> > > Acked-by: Stanislav Fomichev <sdf@fomichev.me>
> > 
> > Thanks for acking! However for some reason clashiko missed this set, can
> > someone remind me what could be the case here?
> > 
> > I also see in SUIE that check_selftest failed - is it mandatory to repost
> > in this case?
> 
> ```
> Bad format: tools/testing/selftests/net/Makefile
> ```
> 
> Not super descriptive :-(
> 
> Maybe check on your side if this is complaining about something legit?
> 
> https://github.com/linux-netdev/nipa/blob/main/tests/patch/check_selftest/validate_makefile_format.py

It is upset about redefining TEST_GEN_FILES on patch 4. Will send a v2
that fixes it.