Netdev List
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org,
	pabeni@redhat.com, edumazet@kernel.org, horms@kernel.org,
	fw@strlen.de, ja@ssi.bg
Subject: Re: [PATCH net-next 00/15] Netfilter updates for net-next
Date: Mon, 16 Nov 2026 00:46:53 +0100	[thread overview]
Message-ID: <avpEbealnVae3W22@chamomile> (raw)
In-Reply-To: <20261113031251.2437074-1-pablo@netfilter.org>

Hi,

I'm attaching a quick summary to address the LLM generated reports:

Patch #1 LLM reviewer refers to CLOSING state which is not covered by
this patch, which is aiming at the TEARDOWN state.

Patch #2 still needs to use the dst that is passed via flow_tuple,
ie. use tuple dst_cache.

Patch #3 LLM reviewer refers to a possible different scenario where
stats can get lost, ie. conntrack -D or -F. I don't think that belongs
to this patch, this possibly need a delayed ct event delivery for 

Patch #4 and #5 LLM reviewer provides hints to improve drivers, these
patches only adapted the existing code to fetch stats from the delete
entry command.

Patch #8 LLM reviewer refers to missing update in selftest, which
breaks.

Patch #11 LLM reviewer mentions that the new selftest script does not
cover for all UDP checksum scenarios in the flowtable. I don't see a
review why this cannot be improved in a follow up.

For patches #2 and #8 a version 2 of these PR might be needed.

But for the remaining patches, I think it is not the way to go to
address the issues described in those patches.

I can repost a v2 without patches #2 and #8.

Anything else, LGTM as is.

On Fri, Nov 13, 2026 at 04:12:36AM +0100, Pablo Neira Ayuso wrote:
> Hi,
> 
> The following patchset contains Netfilter updates for net-next, mostly
> including flowtable fixes and improvements:
> 
> 1) Do not offload flows to hardware from the packet path if they are
>    already being torn down.
> 
> 2) Fix PMTU discovery in nf_flow_tunnel_ip6ip6_push(): update the PMTU
>    before skb_scrub_packet() drops the dst, otherwise the update is
>    silently lost. From Lorenzo Bianconi.
> 
> 3) Fetch hardware stats when a flow is deleted, so the last stats sync
>    with the conntrack entry is no longer missed. Update the mtk_ppe and
>    airoha drivers to use this. From Lorenzo Bianconi and me.
> 
> 4) Fix xt_time monthday computation for dates from 2040 on by using
>    time64_to_tm() instead of the days_since_epoch[] table. This also
>    shrinks the xt_time object by about 23%. From Fernando F. Mancera.
> 
> 5) Do not offload multicast flows from nft_flow_offload, from Koral Ilgun.
> 
> 6) Make the nf_hooks_lwtunnel sysctl read-only in non-init netns so
>    unprivileged users cannot toggle the global static branch.
>    From Pablo Neira Ayuso.
> 
> 7) Purge the remaining flowtable entries directly when the flowtable
>    is destroyed instead of going through the hardware offload
>    workqueue, which may fail to allocate work.
> 
> 8) Remove a no-op loop initializer in the nf_queue selftest to silence
>    a clang -Wunused-value warning. From Sasha Levin.
> 
> 9) Do not scrub the skb as crossing netns in the IPIP flowtable tx
>    path, so the skb mark is preserved.
> 
> 10) Do not let the DEV_PATH_TUN entry set h_source from the tunnel
>     device's dev_addr. Before this patch, fast-path frames went out with
>     part of the tunnel's local IP address as the Ethernet source MAC.
>     This broke offloaded flows on DS-Lite over PPPoE. From Marek
>     Majkowski.
> 
> 11) Clear IPS_OFFLOAD_BIT only once, as part of the one-time teardown
>     transition. Before this patch, a repeated teardown of an expired
>     hardware flow could clear the bit owned by a replacement flow for
>     the same conntrack entry. From João Silva.
> 
> 12) Call skb_ensure_writable() in nfnetlink_queue before writing
>     NFQA_L2HDR over the mac header. Before this patch, the write could
>     corrupt cloned frames that bridge flooding sends to other ports.
>     From Tamaki Yanagawa.
> 
> 13) Add a UDP flowtable offload selftest for IPv4 and IPv6, with and
>     without masquerade. From Jiri Peska.
> 
> Please, pull these changes from:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-next.git nf-next-26-11-13
> 
> Thanks.
> 
> ----------------------------------------------------------------
> 
> The following changes since commit 573af801552999954caa8347e4490b04cf4763f0:
> 
>   Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net (2026-11-12 14:54:47 -0800)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-next.git nf-next-26-11-13
> 
> for you to fetch changes up to 4810f60b9f0e9111cd0dcbfd2ca7a7c591a57464:
> 
>   selftests: netfilter: add UDP flowtable offload test (2026-11-13 04:06:51 +0100)
> 
> ----------------------------------------------------------------
> netfilter pull request 26-11-13
> 
> ----------------------------------------------------------------
> Fernando Fernandez Mancera (1):
>       netfilter: xt_time: fix monthday computation for dates past 2039
> 
> Jiri Peska (1):
>       selftests: netfilter: add UDP flowtable offload test
> 
> João Silva (1):
>       netfilter: flowtable: do not clear the offload bit twice
> 
> Koral Ilgun (1):
>       netfilter: nft_flow_offload: do not offload multicast
> 
> Lorenzo Bianconi (2):
>       netfilter: flowtable: fix pmtu discovery in nf_flow_tunnel_ip6ip6_push()
>       net: airoha: update stats on flow deletion
> 
> Marek Majkowski (1):
>       netfilter: flowtable: tunnel device poisons h_source of fast-path frames
> 
> Pablo Neira Ayuso (6):
>       netfilter: flowtable: do not hw offload flows in teardown state
>       netfilter: flowtable: retrieve stats on flow deletion
>       net: ethernet: mtk_ppe: update stats on flow deletion
>       netfilter: lwtunnel: expose read-only sysctl nf_hooks_lwtunnel for non init-netns
>       netfilter: flowtable: purge entries immediately when destroying the flowtable
>       netfilter: flowtable: do not scrub as crossing netns
> 
> Sasha Levin (1):
>       selftests: netfilter: nf_queue: drop the no-op loop initializer
> 
> Tamaki Yanagawa (1):
>       netfilter: nfnetlink_queue: make skb writable before writing NFQA_L2HDR
> 
>  drivers/net/ethernet/airoha/airoha_ppe.c           |  31 +--
>  drivers/net/ethernet/mediatek/mtk_ppe_offload.c    |  32 ++-
>  include/net/netfilter/nf_flow_table.h              |   3 +-
>  net/netfilter/nf_flow_table_core.c                 |  35 ++-
>  net/netfilter/nf_flow_table_ip.c                   |   4 +-
>  net/netfilter/nf_flow_table_offload.c              |  83 ++++---
>  net/netfilter/nf_flow_table_path.c                 |   7 +-
>  net/netfilter/nf_hooks_lwtunnel.c                  |  12 +-
>  net/netfilter/nfnetlink_queue.c                    |   7 +-
>  net/netfilter/nft_flow_offload.c                   |   5 +
>  net/netfilter/xt_time.c                            |  82 +------
>  tools/testing/selftests/net/netfilter/Makefile     |   1 +
>  tools/testing/selftests/net/netfilter/nf_queue.c   |   2 +-
>  .../selftests/net/netfilter/nft_flowtable_udp.sh   | 238 +++++++++++++++++++++
>  14 files changed, 398 insertions(+), 144 deletions(-)
>  create mode 100755 tools/testing/selftests/net/netfilter/nft_flowtable_udp.sh
> 

  parent reply	other threads:[~2026-11-15 23:46 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  3:12 [PATCH net-next 00/15] Netfilter updates for net-next Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 01/15] netfilter: flowtable: do not hw offload flows in teardown state Pablo Neira Ayuso
2026-11-13  3:17   ` netdev-bot+sinfo
2026-11-13  3:24     ` Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:12     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 02/15] netfilter: flowtable: fix pmtu discovery in nf_flow_tunnel_ip6ip6_push() Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:19     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 03/15] netfilter: flowtable: retrieve stats on flow deletion Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:22     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 04/15] net: ethernet: mtk_ppe: update " Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:26     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 05/15] net: airoha: " Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:26     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 06/15] netfilter: xt_time: fix monthday computation for dates past 2039 Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-13  3:12 ` [PATCH net-next 07/15] netfilter: nft_flow_offload: do not offload multicast Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-13  3:12 ` [PATCH net-next 08/15] netfilter: lwtunnel: expose read-only sysctl nf_hooks_lwtunnel for non init-netns Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:29     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 09/15] netfilter: flowtable: purge entries immediately when destroying the flowtable Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-13  3:12 ` [PATCH net-next 10/15] selftests: netfilter: nf_queue: drop the no-op loop initializer Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 11/15] netfilter: flowtable: do not scrub as crossing netns Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:30     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 12/15] netfilter: flowtable: tunnel device poisons h_source of fast-path frames Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-13  3:12 ` [PATCH net-next 13/15] netfilter: flowtable: do not clear the offload bit twice Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 14/15] netfilter: nfnetlink_queue: make skb writable before writing NFQA_L2HDR Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 15/15] selftests: netfilter: add UDP flowtable offload test Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:46 ` Pablo Neira Ayuso [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-10-18  0:56 [PATCH net-next 00/15] Netfilter updates for net-next Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avpEbealnVae3W22@chamomile \
    --to=pablo@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=ja@ssi.bg \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox