Re: [PATCH net 7/9] ethtool: cmis: fix u16-to-u8 truncation of msleep_pre_rpl

[Maxime Chevallier <maxime.chevallier@bootlin.com>]

Hi,

On 5/23/26 01:13, Jakub Kicinski wrote:
> ethtool_cmis_cdb_compose_args() accepts msleep_pre_rpl as u16 but stores
> it into the u8 field ethtool_cmis_cdb_cmd_args::msleep_pre_rpl, silently
> truncating values >= 256. Seven of the nine call sites pass 1000 ms
> (it's the third argument from the end).
> 
> Fixes: a39c84d79625 ("ethtool: cmis_cdb: Add a layer for supporting CDB commands")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Maxime

> ---
> CC: andrew@lunn.ch
> CC: petrm@nvidia.com
> CC: danieller@nvidia.com
> ---
>   net/ethtool/cmis.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/ethtool/cmis.h b/net/ethtool/cmis.h
> index 4a9a946cabf0..778783a0f23c 100644
> --- a/net/ethtool/cmis.h
> +++ b/net/ethtool/cmis.h
> @@ -63,9 +63,9 @@ struct ethtool_cmis_cdb_request {
>    * struct ethtool_cmis_cdb_cmd_args - CDB commands execution arguments
>    * @req: CDB command fields as described in the CMIS standard.
>    * @max_duration: Maximum duration time for command completion in msec.
> + * @msleep_pre_rpl: Waiting time before checking reply in msec.
>    * @read_write_len_ext: Allowable additional number of byte octets to the LPL
>    *			in a READ or a WRITE commands.
> - * @msleep_pre_rpl: Waiting time before checking reply in msec.
>    * @rpl_exp_len: Expected reply length in bytes.
>    * @flags: Validation flags for CDB commands.
>    * @err_msg: Error message to be sent to user space.
> @@ -73,8 +73,8 @@ struct ethtool_cmis_cdb_request {
>   struct ethtool_cmis_cdb_cmd_args {
>   	struct ethtool_cmis_cdb_request req;
>   	u16				max_duration;
> +	u16				msleep_pre_rpl;
>   	u8				read_write_len_ext;
> -	u8				msleep_pre_rpl;
>   	u8                              rpl_exp_len;
>   	u8				flags;
>   	char				*err_msg;