[PATCH net-next] Documentation: net/smc: correct old value of smcr_max_recv_wr

[PATCH net-next] Documentation: net/smc: correct old value of smcr_max_recv_wr

[Mahanta Jambigi]

The smc-sysctl.rst documentation incorrectly stated that the previous
hardcoded maximum number of WR buffers on the receive path (smcr_max_recv_wr)
was 16. The correct historical value used before the introduction of the sysctl
control was 48. Update the documentation to reflect the accurate default value.

Fixes: aef3cdb47bbb net/smc: make wr buffer count configurable
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
Reviewed-by: Sidraya Jayagond <sidraya@linux.ibm.com>
Signed-off-by: Mahanta Jambigi <mjambigi@linux.ibm.com>
---
 Documentation/networking/smc-sysctl.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/networking/smc-sysctl.rst b/Documentation/networking/smc-sysctl.rst
index 904a910f198e..279d15e61899 100644
--- a/Documentation/networking/smc-sysctl.rst
+++ b/Documentation/networking/smc-sysctl.rst
@@ -100,14 +100,14 @@ smcr_max_recv_wr - INTEGER
 	depending on the workload it can be a bottleneck in a sense that threads
 	have to wait for work request buffers to become available. Before the
 	introduction of this control the maximal number of work request buffers
-	available on the receive path used to be hard coded to 16. With this control
+	available on the receive path used to be hard coded to 48. With this control
 	it becomes configurable. The acceptable range is between 2 and 2048.
 
 	Please be aware that all the buffers need to be allocated as a physically
 	continuous array in which each element is a single buffer and has the size
 	of SMC_WR_BUF_SIZE (48) bytes. If the allocation fails, we keep retrying
 	with half of the buffer count until it is ether successful or (unlikely)
-	we dip below the old hard coded value which is 16 where we give up much
+	we dip below the old hard coded value which is 48 where we give up much
 	like before having this control.
 
 	Default: 48
-- 
2.51.0

Re: [PATCH net-next] Documentation: net/smc: correct old value of smcr_max_recv_wr

[Alexandra Winter]

net-next is closed!

On 22.04.26 10:51, Mahanta Jambigi wrote:
> The smc-sysctl.rst documentation incorrectly stated that the previous
> hardcoded maximum number of WR buffers on the receive path (smcr_max_recv_wr)
> was 16. The correct historical value used before the introduction of the sysctl
> control was 48. Update the documentation to reflect the accurate default value.

s/default/historical/
or remove the last sentence

> 
> Fixes: aef3cdb47bbb net/smc: make wr buffer count configurable
> Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
> Reviewed-by: Sidraya Jayagond <sidraya@linux.ibm.com>
> Signed-off-by: Mahanta Jambigi <mjambigi@linux.ibm.com>
> ---
>  Documentation/networking/smc-sysctl.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/networking/smc-sysctl.rst b/Documentation/networking/smc-sysctl.rst
> index 904a910f198e..279d15e61899 100644
> --- a/Documentation/networking/smc-sysctl.rst
> +++ b/Documentation/networking/smc-sysctl.rst
> @@ -100,14 +100,14 @@ smcr_max_recv_wr - INTEGER
>  	depending on the workload it can be a bottleneck in a sense that threads
>  	have to wait for work request buffers to become available. Before the
>  	introduction of this control the maximal number of work request buffers
> -	available on the receive path used to be hard coded to 16. With this control
> +	available on the receive path used to be hard coded to 48. With this control
>  	it becomes configurable. The acceptable range is between 2 and 2048.
>  
>  	Please be aware that all the buffers need to be allocated as a physically
>  	continuous array in which each element is a single buffer and has the size
>  	of SMC_WR_BUF_SIZE (48) bytes. If the allocation fails, we keep retrying
>  	with half of the buffer count until it is ether successful or (unlikely)
		typo in old documentation: s/ether/either/g

> -	we dip below the old hard coded value which is 16 where we give up much
> +	we dip below the old hard coded value which is 48 where we give up much
>  	like before having this control.
>  
>  	Default: 48