From: Hans Verkuil <hverkuil@xs4all.nl>
To: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>,
linux-media@vger.kernel.org, linux-mips@vger.kernel.org,
netdev@vger.kernel.org, linux-can@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v2 2/3] usb/cx231xx: Remove unused value
Date: Mon, 6 Jan 2025 15:07:44 +0100 [thread overview]
Message-ID: <b228c210-73a9-4d4a-b884-7230be59dd82@xs4all.nl> (raw)
In-Reply-To: <20241221111454.1074285-3-ariel.otilibili-anieli@eurecom.fr>
On 21/12/2024 12:06, Ariel Otilibili wrote:
> Coverity-ID: 1269153
> Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
> ---
> drivers/media/usb/cx231xx/cx231xx-avcore.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/usb/cx231xx/cx231xx-avcore.c b/drivers/media/usb/cx231xx/cx231xx-avcore.c
> index 1cfec76b72f3..f2a2d0c39080 100644
> --- a/drivers/media/usb/cx231xx/cx231xx-avcore.c
> +++ b/drivers/media/usb/cx231xx/cx231xx-avcore.c
> @@ -1896,7 +1896,6 @@ int cx231xx_dif_set_standard(struct cx231xx *dev, u32 standard)
> status = vid_blk_write_word(dev, DIF_SOFT_RST_CTRL_REVB,
> 0x00000000);
> /* Save the Spec Inversion value */
> - dif_misc_ctrl_value &= FLD_DIF_SPEC_INV;
Don't remove this line,
> dif_misc_ctrl_value = 0x3A093F10;
instead this should have been |=, just like is done elsewhere in this function.
> } else if (standard &
> (V4L2_STD_SECAM_B | V4L2_STD_SECAM_D | V4L2_STD_SECAM_G |
Also, please just post this as a separate patch to linux-media. It is bad form
to mix subsystems in the same patch series if there is no reason for it.
Regards,
Hans
next prev parent reply other threads:[~2025-01-06 14:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-21 3:44 [PATCH 0/3] broadcom, ethernet/marvell,cx231xx,can/dev: Remove unused values and dead code Ariel Otilibili
2024-12-21 3:44 ` [PATCH 1/3] drivers/firmware/broadcom, ethernet/marvell: Remove unused values Ariel Otilibili
2024-12-21 15:17 ` Andrew Lunn
2024-12-21 3:44 ` [PATCH 2/3] usb/cx231xx: Remove unused value Ariel Otilibili
2024-12-21 3:44 ` [PATCH 3/3] net/can/dev: Remove dead code Ariel Otilibili
2024-12-21 15:20 ` Andrew Lunn
2024-12-21 11:06 ` [PATCH v2 0/3] broadcom, ethernet/marvell,cx231xx,can/dev: Remove unused values and " Ariel Otilibili
2024-12-21 11:06 ` [PATCH v2 1/3] drivers/firmware/broadcom, ethernet/marvell: Remove unused values Ariel Otilibili
2024-12-21 11:06 ` [PATCH v2 2/3] usb/cx231xx: Remove unused value Ariel Otilibili
2025-01-06 14:07 ` Hans Verkuil [this message]
2024-12-21 11:06 ` [PATCH v2 3/3] net/can/dev: Remove dead code Ariel Otilibili
2024-12-22 16:37 ` Marc Kleine-Budde
2024-12-22 17:27 ` Ariel Otilibili-Anieli
2024-12-21 15:22 ` [PATCH v2 0/3] broadcom, ethernet/marvell,cx231xx,can/dev: Remove unused values and " Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b228c210-73a9-4d4a-b884-7230be59dd82@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=ariel.otilibili-anieli@eurecom.fr \
--cc=linux-can@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox