Re: [PATCH 1/3] drivers/firmware/broadcom, ethernet/marvell: Remove unused values

[Andrew Lunn <andrew@lunn.ch>]

On Sat, Dec 21, 2024 at 04:44:15AM +0100, Ariel Otilibili wrote:
> Coverity-IDs: 1487817, 1561102
> Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>

One patch per driver please.

> --- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
> @@ -329,11 +329,9 @@ static int cn10k_mcs_write_rx_flowid(struct otx2_nic *pfvf,
>  	mac_da = ether_addr_to_u64(secy->netdev->dev_addr);
>  
>  	req->data[0] = FIELD_PREP(MCS_TCAM0_MAC_DA_MASK, mac_da);
> -	req->mask[0] = ~0ULL;
>  	req->mask[0] = ~MCS_TCAM0_MAC_DA_MASK;
>  
>  	req->data[1] = FIELD_PREP(MCS_TCAM1_ETYPE_MASK, ETH_P_MACSEC);
> -	req->mask[1] = ~0ULL;
>  	req->mask[1] &= ~MCS_TCAM1_ETYPE_MASK;
>  

As i said to another patch, you need to argue why you change is
correct. If you have no idea what the correct fix is, you should
simply report the issue to the Maintainer, and look at the git history
for these lines and see who added them, and ask them what is the
correct fix.

	Andrew